refactor: Apply rector changes

Signed-off-by: provokateurin <kate@provokateurin.de>

Author: provokateurin

lib/ACL/ACLManager.php

@@ -164,7 +164,7 @@ public function getPermissionsForPathFromRules(int $folderId, string $path, arra
 			}
 		}
 
-		uksort($filteredRules, static fn (string $a, string $b) => strlen($a) <=> strlen($b));
+		uksort($filteredRules, static fn (string $a, string $b): int => strlen($a) <=> strlen($b));
 
 		return $this->calculatePermissionsForPath($folderId, $filteredRules);
 	}

lib/ACL/RuleManager.php

@@ -36,9 +36,9 @@ private function createRule(array $data): ?Rule {
 		if ($mapping) {
 			return new Rule(
 				$mapping,
-				(int)$data['fileid'],
-				(int)$data['mask'],
-				(int)$data['permissions']
+				$data['fileid'],
+				$data['mask'],
+				$data['permissions']
 			);
 		}
 

lib/Command/ExpireGroup/ExpireGroupBase.php

@@ -16,10 +16,6 @@
  * Base class for the group folder expiration commands.
  */
 class ExpireGroupBase extends Base {
-	public function __construct() {
-		parent::__construct();
-	}
-
 	#[\Override]
 	protected function configure(): void {
 		$this

lib/Command/ListCommand.php

@@ -88,7 +88,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 				$folder['size'] = $folder['root_cache_entry']->getSize();
 				unset($folder['root_cache_entry']);
 				$folder['groups_list'] = array_map(fn (array $group): int => $group['permissions'], $folder['groups']);
-				$folder['options'] = $folder['options'];
 				$folder['mountPoint'] = $folder['mount_point'];
 				unset($folder['mount_point']);
 				$folder['rootId'] = $folder['root_id'];

lib/Folder/FolderManager.php

@@ -159,7 +159,7 @@ public function getAllFoldersWithSize(int $offset = 0, ?int $limit = null, strin
 		/** @var list<array{folder_id: int, mount_point: string, quota: int, acl: bool, acl_default_no_permission: bool, storage_id: int, root_id: int, options: string}> $rows */
 		$rows = $query->executeQuery()->fetchAll();
 
-		$folderIds = array_map(static fn (array $row): int => (int)$row['folder_id'], $rows);
+		$folderIds = array_map(static fn (array $row): int => $row['folder_id'], $rows);
 		$applicableMap = $this->getAllApplicable($folderIds);
 		$folderMappings = $this->getAllFolderMappings($folderIds);
 
@@ -200,7 +200,7 @@ public function getAllFoldersForUserWithSize(IUser $user): array {
 		/** @var list<array{folder_id: int, mount_point: string, quota: int, acl: bool, acl_default_no_permission: bool, storage_id: int, root_id: int, options: string}> $rows */
 		$rows = $query->executeQuery()->fetchAll();
 
-		$folderIds = array_map(static fn (array $row): int => (int)$row['folder_id'], $rows);
+		$folderIds = array_map(static fn (array $row): int => $row['folder_id'], $rows);
 		$applicableMap = $this->getAllApplicable($folderIds);
 		$folderMappings = $this->getAllFolderMappings($folderIds);
 
@@ -544,7 +544,7 @@ public function searchGroups(int $id, string $search = ''): array {
 			return $groups;
 		}
 
-		return array_values(array_filter($groups, fn (array $group): bool => (stripos($group['gid'], $search) !== false) || (stripos($group['displayname'], $search) !== false)));
+		return array_values(array_filter($groups, fn (array $group): bool => (stripos((string)$group['gid'], $search) !== false) || (stripos((string)$group['displayname'], $search) !== false)));
 	}
 
 	/**
@@ -557,7 +557,7 @@ public function searchCircles(int $id, string $search = ''): array {
 			return $circles;
 		}
 
-		return array_values(array_filter($circles, fn (array $circle): bool => (stripos($circle['displayname'], $search) !== false)));
+		return array_values(array_filter($circles, fn (array $circle): bool => (stripos((string)$circle['displayname'], $search) !== false)));
 	}
 
 	/**
@@ -700,7 +700,7 @@ public function getFoldersForGroups(array $groupIds, ?int $folderId = null, ?arr
 			return FolderDefinitionWithPermissions::fromFolder(
 				$folder,
 				Cache::cacheEntryFromData($row, $this->mimeTypeLoader),
-				(int)$row['group_permissions']
+				$row['group_permissions']
 			);
 		}, $result);
 	}

lib/Trash/TrashManager.php

@@ -33,13 +33,13 @@ public function listTrashForFolders(array $folderIds): array {
 		$rows = $query->executeQuery()->fetchAll();
 
 		return array_map(fn (array $row): array => [
-			'trash_id' => (int)$row['trash_id'],
-			'name' => (string)$row['name'],
-			'deleted_time' => (int)$row['deleted_time'],
-			'original_location' => (string)$row['original_location'],
-			'folder_id' => (int)$row['folder_id'],
-			'file_id' => $row['file_id'] !== null ? (int)$row['file_id'] : null,
-			'deleted_by' => $row['deleted_by'] !== null ? (string)$row['deleted_by'] : null,
+			'trash_id' => $row['trash_id'],
+			'name' => $row['name'],
+			'deleted_time' => $row['deleted_time'],
+			'original_location' => $row['original_location'],
+			'folder_id' => $row['folder_id'],
+			'file_id' => $row['file_id'] ?? null,
+			'deleted_by' => $row['deleted_by'] ?? null,
 		], $rows);
 	}