lazy load most app config values, store them as lazy too

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Author: julien-nc

lib/Cron/CleanupQuotaDb.php

@@ -36,7 +36,8 @@ protected function run($argument) {
 				intval($this->appConfig->getValueString(
 					Application::APP_ID,
 					'quota_period',
-					strval(Application::DEFAULT_QUOTA_PERIOD)
+					strval(Application::DEFAULT_QUOTA_PERIOD),
+					true,
 				)),
 				Application::DEFAULT_QUOTA_PERIOD
 			)

lib/Migration/Version030102Date20241003155512.php

@@ -37,7 +37,7 @@ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array
 			$value = $this->appConfig->getValueString(Application::APP_ID, $key);
 			if ($value !== '') {
 				$encryptedValue = $this->crypto->encrypt($value);
-				$this->appConfig->setValueString(Application::APP_ID, $key, $encryptedValue);
+				$this->appConfig->setValueString(Application::APP_ID, $key, $encryptedValue, lazy: true);
 			}
 		}
 

lib/Migration/Version030103Date20241009172829.php

@@ -34,7 +34,7 @@ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array
 			$value = $this->appConfig->getValueString(Application::APP_ID, $key);
 			if ($value !== '') {
 				$decryptedValue = $this->crypto->decrypt($value);
-				$this->appConfig->setValueString(Application::APP_ID, $key, $decryptedValue, false, true);
+				$this->appConfig->setValueString(Application::APP_ID, $key, $decryptedValue, true, true);
 			}
 		}
 	}

lib/Service/OpenAiAPIService.php

@@ -624,7 +624,7 @@ public function createChatCompletion(
 	 * @return array|null
 	 */
 	private function getAdminExtraParams(string $configKey): ?array {
-		$stringValue = $this->appConfig->getValueString(Application::APP_ID, $configKey);
+		$stringValue = $this->appConfig->getValueString(Application::APP_ID, $configKey, lazy: true);
 		if ($stringValue === '') {
 			return null;
 		}
@@ -838,8 +838,8 @@ public function requestSpeechCreation(
 	 */
 	public function getExpTextProcessingTime(): int {
 		return $this->isUsingOpenAi()
-			? intval($this->appConfig->getValueString(Application::APP_ID, 'openai_text_generation_time', strval(Application::DEFAULT_OPENAI_TEXT_GENERATION_TIME)))
-			: intval($this->appConfig->getValueString(Application::APP_ID, 'localai_text_generation_time', strval(Application::DEFAULT_LOCALAI_TEXT_GENERATION_TIME)));
+			? intval($this->appConfig->getValueString(Application::APP_ID, 'openai_text_generation_time', strval(Application::DEFAULT_OPENAI_TEXT_GENERATION_TIME), lazy: true))
+			: intval($this->appConfig->getValueString(Application::APP_ID, 'localai_text_generation_time', strval(Application::DEFAULT_LOCALAI_TEXT_GENERATION_TIME), lazy: true));
 	}
 
 	/**
@@ -851,9 +851,9 @@ public function updateExpTextProcessingTime(int $runtime): void {
 		$newTime = (1.0 - Application::EXPECTED_RUNTIME_LOWPASS_FACTOR) * $oldTime + Application::EXPECTED_RUNTIME_LOWPASS_FACTOR * floatval($runtime);
 
 		if ($this->isUsingOpenAi()) {
-			$this->appConfig->setValueString(Application::APP_ID, 'openai_text_generation_time', strval(intval($newTime)));
+			$this->appConfig->setValueString(Application::APP_ID, 'openai_text_generation_time', strval(intval($newTime)), lazy: true);
 		} else {
-			$this->appConfig->setValueString(Application::APP_ID, 'localai_text_generation_time', strval(intval($newTime)));
+			$this->appConfig->setValueString(Application::APP_ID, 'localai_text_generation_time', strval(intval($newTime)), lazy: true);
 		}
 	}
 
@@ -862,8 +862,8 @@ public function updateExpTextProcessingTime(int $runtime): void {
 	 */
 	public function getExpImgProcessingTime(): int {
 		return $this->isUsingOpenAi()
-			? intval($this->appConfig->getValueString(Application::APP_ID, 'openai_image_generation_time', strval(Application::DEFAULT_OPENAI_IMAGE_GENERATION_TIME)))
-			: intval($this->appConfig->getValueString(Application::APP_ID, 'localai_image_generation_time', strval(Application::DEFAULT_LOCALAI_IMAGE_GENERATION_TIME)));
+			? intval($this->appConfig->getValueString(Application::APP_ID, 'openai_image_generation_time', strval(Application::DEFAULT_OPENAI_IMAGE_GENERATION_TIME), lazy: true))
+			: intval($this->appConfig->getValueString(Application::APP_ID, 'localai_image_generation_time', strval(Application::DEFAULT_LOCALAI_IMAGE_GENERATION_TIME), lazy: true));
 	}
 
 	/**
@@ -875,9 +875,9 @@ public function updateExpImgProcessingTime(int $runtime): void {
 		$newTime = (1.0 - Application::EXPECTED_RUNTIME_LOWPASS_FACTOR) * $oldTime + Application::EXPECTED_RUNTIME_LOWPASS_FACTOR * floatval($runtime);
 
 		if ($this->isUsingOpenAi()) {
-			$this->appConfig->setValueString(Application::APP_ID, 'openai_image_generation_time', strval(intval($newTime)));
+			$this->appConfig->setValueString(Application::APP_ID, 'openai_image_generation_time', strval(intval($newTime)), lazy: true);
 		} else {
-			$this->appConfig->setValueString(Application::APP_ID, 'localai_image_generation_time', strval(intval($newTime)));
+			$this->appConfig->setValueString(Application::APP_ID, 'localai_image_generation_time', strval(intval($newTime)), lazy: true);
 		}
 	}