fix: use admin specified max tokens as default for all tasks it makes sense for

lukasdotcom · lukasdotcom · commit 6bd5c72f64a9 · 2025-07-18T11:05:36.000-04:00
Signed-off-by: Lukas Schaefer &lt;lukas@lschaefer.xyz&gt;
diff --git a/lib/TaskProcessing/AnalyzeImagesProvider.php b/lib/TaskProcessing/AnalyzeImagesProvider.php
@@ -87,7 +87,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}
diff --git a/lib/TaskProcessing/ChangeToneProvider.php b/lib/TaskProcessing/ChangeToneProvider.php
@@ -96,7 +96,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}
diff --git a/lib/TaskProcessing/ContextWriteProvider.php b/lib/TaskProcessing/ContextWriteProvider.php
@@ -82,7 +82,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}
diff --git a/lib/TaskProcessing/ProofreadProvider.php b/lib/TaskProcessing/ProofreadProvider.php
@@ -82,7 +82,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}
diff --git a/lib/TaskProcessing/ReformulateProvider.php b/lib/TaskProcessing/ReformulateProvider.php
@@ -82,7 +82,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}
diff --git a/lib/TaskProcessing/SummaryProvider.php b/lib/TaskProcessing/SummaryProvider.php
@@ -82,7 +82,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}
diff --git a/lib/TaskProcessing/TranslateProvider.php b/lib/TaskProcessing/TranslateProvider.php
@@ -100,7 +100,7 @@ public function getOptionalInputShapeDefaults(): array {
 			? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)
 			: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');
 		return [
-			'max_tokens' => 1000,
+			'max_tokens' => $this->openAiSettingsService->getMaxTokens(),
 			'model' => $adminModel,
 		];
 	}

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public function getOptionalInputShapeDefaults(): array {`
`87`	`87`	`? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)`
`88`	`88`	`: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');`
`89`	`89`	`return [`
`90`		`- 'max_tokens' => 1000,`
	`90`	`+ 'max_tokens' => $this->openAiSettingsService->getMaxTokens(),`
`91`	`91`	`'model' => $adminModel,`
`92`	`92`	`];`
`93`	`93`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function getOptionalInputShapeDefaults(): array {`
`96`	`96`	`? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)`
`97`	`97`	`: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');`
`98`	`98`	`return [`
`99`		`- 'max_tokens' => 1000,`
	`99`	`+ 'max_tokens' => $this->openAiSettingsService->getMaxTokens(),`
`100`	`100`	`'model' => $adminModel,`
`101`	`101`	`];`
`102`	`102`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function getOptionalInputShapeDefaults(): array {`
`82`	`82`	`? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)`
`83`	`83`	`: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');`
`84`	`84`	`return [`
`85`		`- 'max_tokens' => 1000,`
	`85`	`+ 'max_tokens' => $this->openAiSettingsService->getMaxTokens(),`
`86`	`86`	`'model' => $adminModel,`
`87`	`87`	`];`
`88`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public function getOptionalInputShapeDefaults(): array {`
`100`	`100`	`? ($this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id', Application::DEFAULT_MODEL_ID) ?: Application::DEFAULT_MODEL_ID)`
`101`	`101`	`: $this->appConfig->getValueString(Application::APP_ID, 'default_completion_model_id');`
`102`	`102`	`return [`
`103`		`- 'max_tokens' => 1000,`
	`103`	`+ 'max_tokens' => $this->openAiSettingsService->getMaxTokens(),`
`104`	`104`	`'model' => $adminModel,`
`105`	`105`	`];`
`106`	`106`	`}`