Set loglevel via ui: code review feedback

* Reduce nesting in VUE
* Check value in backend before writing
* Set WARN as default log level
* VUE exception handling with logging

Author: R0Wi

css/logreader-main.css

@@ -93,6 +93,11 @@ public function updateAppConfig(string $settingsKey, $settingsValue): JSONRespon
 		}
 
 		if ($settingsKey === Constants::CONFIG_KEY_LOGLEVEL) {
+			// Validate loglevel value
+			if (!is_int($settingsValue) || $settingsValue < 0 || $settingsValue > 4) {
+				$this->logger->debug('Cannot set {settingsValue} as loglevel', ['settingsValue' => $settingsValue ]);
+				return new JSONResponse([], Http::STATUS_BAD_REQUEST);
+			}
 			// Set backend loglevel directly via system value
 			$this->config->setSystemValue('loglevel', $settingsValue);
 		} else {

js/logreader-main.mjs

@@ -65,7 +65,7 @@ public function getLiveLog(): bool {
 	public function getAppSettings(): array {
 		return [
 			Constants::CONFIG_KEY_SHOWNLEVELS => $this->getShownLevels(),
-			Constants::CONFIG_KEY_LOGLEVEL => $this->config->getSystemValueInt('loglevel', 0),
+			Constants::CONFIG_KEY_LOGLEVEL => $this->config->getSystemValueInt('loglevel', 2),
 			Constants::CONFIG_KEY_DATETIMEFORMAT => $this->getDateTimeFormat(),
 			Constants::CONFIG_KEY_RELATIVEDATES => $this->getRelativeDates(),
 			Constants::CONFIG_KEY_LIVELOG => $this->getLiveLog(),

js/logreader-main.mjs.map

@@ -1,18 +1,16 @@
 <template>
-	<div>
-		<fieldset>
-			<legend>{{ t('logreader', 'Set backend loglevel') }}</legend>
-			<NcCheckboxRadioSwitch v-for="levelName, levelId in LOGGING_LEVEL_NAMES"
-				:key="levelId"
-				:checked="logLevel"
-				:value="`${levelId}`"
-				type="radio"
-				name="loglevel"
-				@update:checked="setLogLevel">
-				{{ levelName }}
-			</NcCheckboxRadioSwitch>
-		</fieldset>
-	</div>
+	<fieldset>
+		<legend>{{ t('logreader', 'Set backend loglevel') }}</legend>
+		<NcCheckboxRadioSwitch v-for="levelName, levelId in LOGGING_LEVEL_NAMES"
+			:key="levelId"
+			:checked="logLevel"
+			:value="`${levelId}`"
+			type="radio"
+			name="loglevel"
+			@update:checked="setLogLevel">
+			{{ levelName }}
+		</NcCheckboxRadioSwitch>
+	</fieldset>
 </template>
 
 <script setup lang="ts">
@@ -22,6 +20,7 @@ import { computed } from 'vue'
 import { showError } from '@nextcloud/dialogs'
 import { translate as t } from '@nextcloud/l10n'
 import { useSettingsStore } from '../../store/settings'
+import { logger } from '../../utils/logger'
 import { LOGGING_LEVEL_NAMES } from '../../constants'
 
 import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
@@ -36,7 +35,10 @@ const logLevel = computed(() => `${settingsStore.logLevel}`)
 const setLogLevel = (level: string) => {
 	const numericLevel = parseInt(level) as IAppSettings['logLevel']
 	settingsStore.setSetting('logLevel', numericLevel)
-		.catch(() => showError(t('logreader', 'Could not set logging level')))
+		.catch(e => {
+			showError(t('logreader', 'Could not set logging level'))
+			logger.error(e as Error)
+		})
 }
 </script>
 

lib/Controller/SettingsController.php

@@ -24,7 +24,7 @@ export const useSettingsStore = defineStore('logreader-settings', () => {
 	/**
 	 * Saved setting loaded from server
 	 */
-	const _loadedSettings = loadState<SettingsState>('logreader', 'settings', { enabled: false, liveLog: false, dateTimeFormat: 'raw', shownLevels: [], logLevel: 0 })
+	const _loadedSettings = loadState<SettingsState>('logreader', 'settings', { enabled: false, liveLog: false, dateTimeFormat: 'raw', shownLevels: [], logLevel: 2 })
 
 	/**
 	 * Is file logging enabled on server