Merge pull request #1069 from nextcloud/fix/lower-setupcheck-severity

Lower setup check level from error/warning to warning/info

Author: come-nc

lib/SetupChecks/LogErrors.php

@@ -74,7 +74,7 @@ public function run(): SetupResult {
 		if (array_sum($count) === 0) {
 			return SetupResult::success($this->l10n->t('No errors in the logs since %s', $this->dateFormatter->formatDate($limit)));
 		} elseif ($count[self::LEVEL_ERROR] + $count[self::LEVEL_FATAL] > 0) {
-			return SetupResult::error(
+			return SetupResult::warning(
 				$this->l10n->n(
 					'%n error in the logs since %s',
 					'%n errors in the logs since %s',
@@ -83,7 +83,7 @@ public function run(): SetupResult {
 				)
 			);
 		} else {
-			return SetupResult::warning(
+			return SetupResult::info(
 				$this->l10n->n(
 					'%n warning in the logs since %s',
 					'%n warnings in the logs since %s'.json_encode($count),

tests/Unit/SetupChecks/LogErrorsTest.php

@@ -60,10 +60,10 @@ public function logProvider(): array {
 		$tooOld = (new \DateTime('1 month ago'))->format(\DateTime::ATOM);
 		return [
 			[[], 'success'],
-			[[['level' => 2, 'time' => $now]], 'warning'],
-			[[['level' => 3, 'time' => $now]], 'error'],
-			[[['level' => 2, 'time' => $now],['level' => 3, 'time' => $now]], 'error'],
-			[[['level' => 2, 'time' => $now],['level' => 3, 'time' => $tooOld]], 'warning'],
+			[[['level' => 2, 'time' => $now]], 'info'],
+			[[['level' => 3, 'time' => $now]], 'warning'],
+			[[['level' => 2, 'time' => $now],['level' => 3, 'time' => $now]], 'warning'],
+			[[['level' => 2, 'time' => $now],['level' => 3, 'time' => $tooOld]], 'info'],
 			[[['level' => 2, 'time' => $tooOld],['level' => 3, 'time' => $tooOld]], 'success'],
 		];
 	}