chore(eslint): function multiline rules

- @stylistic/function-paren-newline
- @stylistic/implicit-arrow-linebreak
- @stylistic/max-statements-per-line
- curly

Signed-off-by: Maksim Sukharev <[email protected]>

Author: Antreesy

eslint.config.mjs

@@ -13,17 +13,13 @@ export default [
 			'@nextcloud/vue/no-deprecated-exports': 'off',
 			'@nextcloud/vue/no-deprecated-props': 'off',
 			'@stylistic/arrow-parens': 'off',
-			'@stylistic/function-paren-newline': 'off',
-			'@stylistic/implicit-arrow-linebreak': 'off',
 			'@stylistic/indent': 'off',
 			'@stylistic/indent-binary-ops': 'off',
-			'@stylistic/max-statements-per-line': 'off',
 			'@stylistic/member-delimiter-style': 'off',
 			'@stylistic/object-curly-spacing': 'off',
 			'@typescript-eslint/no-unsafe-function-type': 'off',
 			'@typescript-eslint/no-unused-vars': 'off',
 			'@typescript-eslint/no-use-before-define': 'off',
-			'curly': 'off',
 			'import-extensions/extensions': 'off',
 			'vue/first-attribute-linebreak': 'off',
 			'vue/no-boolean-default': 'off',

src/components/IntersectionObserver.vue

@@ -36,14 +36,18 @@ const observable = ref<HTMLDivElement>()
  * The intersection observer
  */
 const observer = new IntersectionObserver((entries) => {
-	if (entries[0].isIntersecting) emit('intersection')
+	if (entries[0].isIntersecting) {
+		emit('intersection')
+	}
 }, props.options)
 
 /**
  * Start observing when mounted
  */
 onMounted(() => {
-	if (observable.value) observer.observe(observable.value)
+	if (observable.value) {
+		observer.observe(observable.value)
+	}
 })
 
 /**

src/components/LogDetailsModal.vue

@@ -99,18 +99,13 @@ watchEffect(() => {
 /**
  * Index of the current entry within all entries
  */
-const index = computed(() =>
-	props.logEntries.findIndex((entry) => entry === props.currentEntry),
-)
+const index = computed(() => props.logEntries.findIndex((entry) => entry === props.currentEntry))
 
 /**
  * Formatted data of the entry
  */
-const code = computed(
-	() =>
-		hljs.highlight(JSON.stringify(props.currentEntry, null, 2), { language: 'json' })
-			.value,
-)
+const code = computed(() => hljs.highlight(JSON.stringify(props.currentEntry, null, 2), { language: 'json' })
+			.value)
 
 /**
  * Level as translated human readable string

src/components/exception/TraceLine.vue

@@ -28,15 +28,12 @@ const props = defineProps<{
 /**
  * The fully qualified function name (including the class name)
  */
-const functionText = computed(
-	() => `${props.line.class}${props.line.type}${props.line.function}`,
-)
+const functionText = computed(() => `${props.line.class}${props.line.type}${props.line.function}`)
 
 /**
  * The arguments of the function
  */
-const argumentText = computed(
-	() => (props.line.args || []).length === 0
+const argumentText = computed(() => (props.line.args || []).length === 0
 		? '()'
 		: (
 			'(\n'
@@ -45,8 +42,7 @@ const argumentText = computed(
 				.map((argument) => JSON.stringify(argument, undefined, 2).split('\n').map((code) => `  ${code}`).join('\n'))
 				.join(',\n')
 			+ '\n)'
-		),
-)
+		))
 </script>
 
 <style lang="scss" scoped>

src/components/settings/SettingsLiveView.vue

@@ -28,8 +28,7 @@ import { logger } from '../../utils/logger'
 const settingsStore = useSettingsStore()
 const liveLog = computed({
 	get: () => settingsStore.enabled ? settingsStore.liveLog : false,
-	set: (v: boolean) =>
-		settingsStore
+	set: (v: boolean) => settingsStore
 			.setSetting('liveLog', v)
 			.catch((e) => {
 				logger.debug(e)

src/components/table/LogTable.vue

@@ -132,7 +132,9 @@ async function loadMore() {
 		if (sortedByTime.value === 'ascending') {
 			const positionOfPreviousElement = logStore.entries.length - sizeBefore + 1 // ensure the loading row is not inside view
 			const previousTopElement = tableBody.value?.querySelector(`tr:nth-of-type(${positionOfPreviousElement})`)
-			if (previousTopElement) previousTopElement.scrollIntoView({ block: 'start' })
+			if (previousTopElement) {
+				previousTopElement.scrollIntoView({ block: 'start' })
+			}
 		}
 	})
 }

src/components/table/LogTableHeader.vue

@@ -88,9 +88,18 @@ const sortIcon = computed(() => {
  */
 function changeSortMode() {
 	switch (props.sorted) {
-	case 'ascending': emit('update:sorted', 'descending'); break
-	case 'descending': emit('update:sorted', ''); break
-	case '': emit('update:sorted', 'ascending'); break
+	case 'ascending': {
+		emit('update:sorted', 'descending')
+		break
+	}
+	case 'descending': {
+		emit('update:sorted', '')
+		break
+	}
+	case '': {
+		emit('update:sorted', 'ascending')
+		break
+	}
 	}
 }
 

src/components/table/LogTableRow.vue

@@ -167,7 +167,9 @@ function resizeTabeRow() {
 	if (isExpanded.value) {
 		nextTick(() => {
 			const height = tableRowElement.value?.scrollHeight || 0
-			if (tableRowElement.value) tableRowElement.value.style.height = `${height}px`
+			if (tableRowElement.value) {
+				tableRowElement.value.style.height = `${height}px`
+			}
 		})
 	} else if (tableRowElement.value !== undefined) {
 		tableRowElement.value.style.height = ''

src/store/logging.spec.ts

@@ -284,7 +284,9 @@ describe('store:logging', () => {
 		})
 
 		// throw an error
-		mocks.parseLogString.mockImplementationOnce(() => { throw new Error() })
+		mocks.parseLogString.mockImplementationOnce(() => {
+			throw new Error()
+		})
 
 		const store = useLogStore()
 		const settings = useSettingsStore()
@@ -621,7 +623,9 @@ describe('store:logging', () => {
 				logger: mocks.logger,
 			}
 		})
-		vi.mocked(mocks.pollLog).mockImplementationOnce(() => { throw Error() })
+		vi.mocked(mocks.pollLog).mockImplementationOnce(() => {
+			throw Error()
+		})
 
 		// clean pinia
 		createTestingPinia({
@@ -650,7 +654,9 @@ describe('store:logging', () => {
 				logger: mocks.logger,
 			}
 		})
-		vi.mocked(mocks.pollLog).mockImplementationOnce(() => { throw new ServerError() })
+		vi.mocked(mocks.pollLog).mockImplementationOnce(() => {
+			throw new ServerError()
+		})
 
 		// clean pinia
 		createTestingPinia({

src/store/logging.ts

@@ -65,10 +65,14 @@ export const useLogStore = defineStore('logreader-logs', () => {
 	 */
 	async function loadMore(older = true) {
 		// Nothing to do if server logging is disabled
-		if (!_settings.isEnabled) return
+		if (!_settings.isEnabled) {
+			return
+		}
 
 		// Only load any entries if there is no previous unfinished request
-		if (!(_loading.value = !_loading.value)) return
+		if (!(_loading.value = !_loading.value)) {
+			return
+		}
 
 		try {
 			if (older) {