fix: Do not register listener when not in console #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering the listener no matter what defeats the perf optimisation done here: https://github.com/nextcloud/server/blob/cb7c82c13d5d6cf0b21b4499365460c605936c5a/lib/private/Log.php#L331-L337 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/optim/dont_register_listener_if_not_console
branch
from
5062634 to
16bd650
Compare
icewind1991
approved these changes
Mar 26, 2025
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering the listener no matter what defeats the perf optimisation done here: