Skip to content

Commit d1fc13a

Browse files
Fix #489 (Security Fix)
1 parent 2bf3c48 commit d1fc13a

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/LoginDialogFragment.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,10 @@
3232
import android.preference.PreferenceManager;
3333
import android.support.v4.app.DialogFragment;
3434
import android.support.v7.app.AlertDialog;
35+
import android.text.Editable;
3536
import android.text.InputType;
3637
import android.text.TextUtils;
38+
import android.text.TextWatcher;
3739
import android.view.LayoutInflater;
3840
import android.view.View;
3941
import android.view.WindowManager;
@@ -146,13 +148,18 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
146148
}
147149

148150
mImageViewShowPwd.setOnClickListener(ImgViewShowPasswordListener);
151+
mPasswordView.addTextChangedListener(PasswordTextChangedListener);
149152

150153
SharedPreferences mPrefs = PreferenceManager.getDefaultSharedPreferences(getActivity());
151154
mUsername = mPrefs.getString(SettingsActivity.EDT_USERNAME_STRING, null);
152155
mPassword = mPrefs.getString(SettingsActivity.EDT_PASSWORD_STRING, null);
153156
mOc_root_path = mPrefs.getString(SettingsActivity.EDT_OWNCLOUDROOTPATH_STRING, null);
154157
mCbDisableHostnameVerification = mPrefs.getBoolean(SettingsActivity.CB_DISABLE_HOSTNAME_VERIFICATION_STRING, false);
155158

159+
if(!mPassword.isEmpty()) {
160+
mImageViewShowPwd.setVisibility(View.GONE);
161+
}
162+
156163
// Set up the login form.
157164
mUsernameView.setText(mUsername);
158165
mPasswordView.setText(mPassword);
@@ -210,6 +217,25 @@ public void onCancel(DialogInterface dialog) {
210217
mActivity.finish();
211218
}
212219

220+
private TextWatcher PasswordTextChangedListener = new TextWatcher() {
221+
@Override
222+
public void beforeTextChanged(CharSequence s, int start, int count, int after) {
223+
224+
}
225+
226+
@Override
227+
public void onTextChanged(CharSequence s, int start, int before, int count) {
228+
229+
}
230+
231+
@Override
232+
public void afterTextChanged(Editable s) {
233+
if(s.toString().isEmpty()) {
234+
mImageViewShowPwd.setVisibility(View.VISIBLE);
235+
}
236+
}
237+
};
238+
213239
private View.OnClickListener ImgViewShowPasswordListener = new View.OnClickListener() {
214240
@Override
215241
public void onClick(View v) {

0 commit comments

Comments
 (0)