Add better error handling if Web API returns Version 0

Author: David-Development

News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/LoginDialogFragment.java

@@ -34,8 +34,11 @@
 import android.support.v7.app.AlertDialog;
 import android.text.Editable;
 import android.text.InputType;
+import android.text.SpannableString;
 import android.text.TextUtils;
 import android.text.TextWatcher;
+import android.text.method.LinkMovementMethod;
+import android.text.util.Linkify;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.WindowManager;
@@ -45,6 +48,7 @@
 import android.widget.CompoundButton.OnCheckedChangeListener;
 import android.widget.EditText;
 import android.widget.ImageView;
+import android.widget.TextView;
 
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -375,14 +379,17 @@ protected void onPostExecute(final Integer versionCode) {
 			mDialogLogin.dismiss();
 
 			if(versionCode == -1 && exception_message.equals("Value <!DOCTYPE of type java.lang.String cannot be converted to JSONObject")) {
-				if(isAdded())
+				if(isAdded()) {
 					ShowAlertDialog(getString(R.string.login_dialog_title_error), getString(R.string.login_dialog_text_not_compatible), getActivity());
+				}
 			} else if(versionCode == -1) {
-				if(isAdded())
+				if(isAdded()) {
 					ShowAlertDialog(getString(R.string.login_dialog_title_error), exception_message, getActivity());
+				}
 			} else if(versionCode == 0){
-				if(isAdded())
-					ShowAlertDialog(getString(R.string.login_dialog_title_error), getString(R.string.login_dialog_text_something_went_wrong), getActivity());
+				if(isAdded()) {
+					ShowAlertDialog(getString(R.string.login_dialog_title_error), getString(R.string.login_dialog_text_zero_version_code), getActivity());
+				}
 			} else {
 				//Reset Database
 				DatabaseConnectionOrm dbConn = new DatabaseConnectionOrm(getActivity());
@@ -414,10 +421,18 @@ protected void onCancelled() {
 
 	public static void ShowAlertDialog(String title, String text, Activity activity)
 	{
-		AlertDialog.Builder aDialog = new AlertDialog.Builder(activity);
-		aDialog.setTitle(title);
-		aDialog.setMessage(text);
-		aDialog.setPositiveButton(activity.getString(android.R.string.ok) , null);
-		aDialog.create().show();
+		// Linkify the message
+		final SpannableString s = new SpannableString(text);
+		Linkify.addLinks(s, Linkify.ALL);
+
+		AlertDialog aDialog = new AlertDialog.Builder(activity)
+				.setTitle(title)
+				.setMessage(s)
+				.setPositiveButton(activity.getString(android.R.string.ok) , null)
+				.create();
+		aDialog.show();
+
+		// Make the textview clickable. Must be called after show()
+		((TextView)aDialog.findViewById(android.R.id.message)).setMovementMethod(LinkMovementMethod.getInstance());
 	}
 }

News-Android-App/src/main/res/values/strings.xml

@@ -212,6 +212,7 @@
     <!-- Login Dialog -->
     <string name="login_dialog_title_error">Error</string>
     <string name="login_dialog_text_something_went_wrong">Something went wrong :(</string>
+    <string name="login_dialog_text_zero_version_code">The Web News App returned Version "0". Please take a look at the following bug report: https://github.com/nextcloud/news/issues/5#issuecomment-242883795</string>
     <string name="login_dialog_text_not_compatible">This App version is not compatible with your ownCloud News App. Please update the news app and the appframework.</string>
     <string name="login_dialog_title_security_warning">Security Warning</string>
     <string name="login_dialog_text_security_warning">You\'re not using https. An attacker could intercept your traffic and gain access to some sensitive data (e.g. your password). So it\'s strongly recommend to use https!</string>