simplify logic in extension

Signed-off-by: alperozturk <[email protected]>

Author: alperozturk96

app/src/main/java/it/niedermann/owncloud/notes/persistence/CapabilitiesClient.java

@@ -13,12 +13,10 @@
 import androidx.annotation.Nullable;
 import androidx.annotation.WorkerThread;
 
-import com.nextcloud.android.sso.api.EmptyResponse;
 import com.nextcloud.android.sso.model.SingleSignOnAccount;
 
-import java.util.Objects;
-
 import it.niedermann.owncloud.notes.shared.model.Capabilities;
+import it.niedermann.owncloud.notes.util.ThrowableExtensionsKt;
 
 @WorkerThread
 public class CapabilitiesClient {
@@ -46,7 +44,7 @@ public static Capabilities getCapabilities(@NonNull Context context, @NonNull Si
 
             return capabilities;
         } catch (Throwable t) {
-            if (t instanceof ClassCastException castException && Objects.requireNonNull(castException.getMessage()).contains(EmptyResponse.class.getSimpleName())) {
+            if (ThrowableExtensionsKt.isEmptyResponseCast(t)) {
                 Log.d(TAG, "Server returned empty response - Notes not modified.");
                 return repository.getCapabilities();
             }

app/src/main/java/it/niedermann/owncloud/notes/persistence/NotesServerSyncTask.java

@@ -44,6 +44,7 @@
 import it.niedermann.owncloud.notes.shared.model.ISyncCallback;
 import it.niedermann.owncloud.notes.shared.model.SyncResultStatus;
 import it.niedermann.owncloud.notes.shared.util.ApiVersionUtil;
+import it.niedermann.owncloud.notes.util.ThrowableExtensionsKt;
 
 
 /**
@@ -282,7 +283,7 @@ private boolean pullRemoteChanges() {
             return true;
         } catch (Throwable t) {
             final Throwable cause = t.getCause();
-            if (t instanceof ClassCastException castException && Objects.requireNonNull(castException.getMessage()).contains(EmptyResponse.class.getSimpleName())) {
+            if (ThrowableExtensionsKt.isEmptyResponseCast(t)) {
                 Log.d(TAG, "Server returned empty response - Notes not modified.");
                 return true;
             }

app/src/main/java/it/niedermann/owncloud/notes/util/ThrowableExtensions.kt

@@ -0,0 +1,14 @@
+/*
+ * Nextcloud Notes - Android Client
+ *
+ * SPDX-FileCopyrightText: 2021-2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+package it.niedermann.owncloud.notes.util
+
+import com.nextcloud.android.sso.api.EmptyResponse
+
+fun Throwable.isEmptyResponseCast(): Boolean {
+    return this is ClassCastException &&
+            (message?.contains(EmptyResponse::class.simpleName ?: "") == true)
+}