binding npe

Signed-off-by: alperozturk <[email protected]>

Author: alperozturk96

app/src/main/java/it/niedermann/owncloud/notes/edit/NoteDirectEditFragment.kt

@@ -50,8 +50,8 @@ import java.util.concurrent.TimeUnit
 
 class NoteDirectEditFragment : BaseNoteFragment(), Branded {
     private var _binding: FragmentNoteDirectEditBinding? = null
-    private val binding: FragmentNoteDirectEditBinding
-        get() = _binding!!
+    private val binding: FragmentNoteDirectEditBinding?
+        get() = _binding
 
     private val disposables: DisposableSet = DisposableSet()
     private var switchToEditPending = false
@@ -81,41 +81,44 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
         inflater: LayoutInflater,
         container: ViewGroup?,
         savedInstanceState: Bundle?,
-    ): View {
+    ): View? {
         Log.d(TAG, "onCreateView() called")
         _binding = FragmentNoteDirectEditBinding.inflate(inflater, container, false)
         setupFab()
         prepareWebView()
-        return binding.root
+        return binding?.root
     }
 
     @SuppressLint("ClickableViewAccessibility") // touch listener only for UI purposes, no need to handle click
     private fun setupFab() {
-        binding.plainEditingFab.isExtended = false
-        ExtendedFabUtil.toggleExtendedOnLongClick(binding.plainEditingFab)
-        // manually detect scroll as we can't get it from the webview (maybe with custom JS?)
-        binding.noteWebview.setOnTouchListener { _, event ->
-            when (event.action) {
-                MotionEvent.ACTION_DOWN -> {
-                    scrollStart = event.y.toInt()
-                }
-                MotionEvent.ACTION_UP -> {
-                    val scrollEnd = event.y.toInt()
-                    ExtendedFabUtil.toggleVisibilityOnScroll(
-                        binding.plainEditingFab,
-                        scrollStart,
-                        scrollEnd,
-                    )
+        binding?.run {
+            plainEditingFab.isExtended = false
+            ExtendedFabUtil.toggleExtendedOnLongClick(plainEditingFab)
+
+            // manually detect scroll as we can't get it from the webview (maybe with custom JS?)
+            noteWebview.setOnTouchListener { _, event ->
+                when (event.action) {
+                    MotionEvent.ACTION_DOWN -> {
+                        scrollStart = event.y.toInt()
+                    }
+                    MotionEvent.ACTION_UP -> {
+                        val scrollEnd = event.y.toInt()
+                        ExtendedFabUtil.toggleVisibilityOnScroll(
+                            plainEditingFab,
+                            scrollStart,
+                            scrollEnd,
+                        )
+                    }
                 }
+                return@setOnTouchListener false
             }
-            return@setOnTouchListener false
+            plainEditingFab.setOnClickListener { switchToPlainEdit() }
         }
-        binding.plainEditingFab.setOnClickListener { switchToPlainEdit() }
     }
 
     private fun switchToPlainEdit() {
         switchToEditPending = true
-        binding.noteWebview.evaluateJavascript(JS_CLOSE) { result ->
+        binding?.noteWebview?.evaluateJavascript(JS_CLOSE) { result ->
             val resultWithoutQuotes = result.replace("\"", "")
             if (resultWithoutQuotes != JS_RESULT_OK) {
                 Log.w(TAG, "Closing via JS failed: $resultWithoutQuotes")
@@ -128,7 +131,7 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
     override fun onDestroyView() {
         super.onDestroyView()
         disposables.dispose()
-        binding.noteWebview.destroy()
+        binding?.noteWebview?.destroy()
         _binding = null
     }
 
@@ -137,7 +140,7 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
         val timeoutDisposable = Single.just(Unit)
             .delay(LOAD_TIMEOUT_SECONDS, TimeUnit.SECONDS)
             .map {
-                if (!binding.noteWebview.isVisible) {
+                if (binding?.noteWebview?.isVisible == false) {
                     Log.w(TAG, "Editor not loaded after $LOAD_TIMEOUT_SECONDS seconds")
                     handleLoadError()
                 }
@@ -197,7 +200,7 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
                         if (BuildConfig.DEBUG) {
                             Log.d(TAG, "loadNoteInWebView: url = $url")
                         }
-                        binding.noteWebview.loadUrl(url)
+                        binding?.noteWebview?.loadUrl(url)
                     }
                 }, { throwable ->
                     handleLoadError()
@@ -208,30 +211,32 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
     }
 
     private fun handleLoadError() {
-        val snackbar = BrandedSnackbar.make(
-            binding.plainEditingFab,
-            getString(R.string.direct_editing_error),
-            Snackbar.LENGTH_INDEFINITE,
-        )
-
-        if (note != null) {
-            snackbar.setAction(R.string.switch_to_plain_editing) {
-                changeToEditMode()
-            }
-        } else {
-            snackbar.setAction(R.string.action_back) {
-                close()
+        binding?.run {
+            val snackbar = BrandedSnackbar.make(
+                plainEditingFab,
+                getString(R.string.direct_editing_error),
+                Snackbar.LENGTH_INDEFINITE,
+            )
+
+            if (note != null) {
+                snackbar.setAction(R.string.switch_to_plain_editing) {
+                    changeToEditMode()
+                }
+            } else {
+                snackbar.setAction(R.string.action_back) {
+                    close()
+                }
             }
-        }
 
-        snackbar.show()
+            snackbar.show()
+        }
     }
 
     override fun shouldShowToolbar(): Boolean = false
 
     @SuppressLint("SetJavaScriptEnabled")
     private fun prepareWebView() {
-        binding.noteWebview.settings.run {
+        binding?.noteWebview?.settings?.run {
             // enable zoom
             setSupportZoom(true)
             builtInZoomControls = true
@@ -260,15 +265,15 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
 
         if (BuildConfig.DEBUG) {
             // caching disabled in debug mode
-            binding.noteWebview.settings.cacheMode = WebSettings.LOAD_NO_CACHE
+            binding?.noteWebview?.settings?.cacheMode = WebSettings.LOAD_NO_CACHE
         }
 
-        binding.noteWebview.addJavascriptInterface(
+        binding?.noteWebview?.addJavascriptInterface(
             DirectEditingMobileInterface(this),
             JS_INTERFACE_NAME,
         )
 
-        binding.noteWebview.webViewClient = object : WebViewClient() {
+        binding?.noteWebview?.webViewClient = object : WebViewClient() {
             override fun onReceivedError(
                 view: WebView?,
                 request: WebResourceRequest?,
@@ -316,8 +321,11 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
 
     override fun applyBrand(color: Int) {
         val util = BrandingUtil.of(color, requireContext())
-        util.material.themeExtendedFAB(binding.plainEditingFab)
-        util.platform.colorCircularProgressBar(binding.progress, ColorRole.PRIMARY)
+
+        binding?.run {
+            util.material.themeExtendedFAB(plainEditingFab)
+            util.platform.colorCircularProgressBar(progress, ColorRole.PRIMARY)
+        }
     }
 
     private class DirectEditingMobileInterface(val noteDirectEditFragment: NoteDirectEditFragment) {
@@ -382,9 +390,11 @@ class NoteDirectEditFragment : BaseNoteFragment(), Branded {
 
     private fun toggleLoadingUI(loading: Boolean) {
         activity?.runOnUiThread {
-            binding.progress.isVisible = loading
-            binding.noteWebview.isVisible = !loading
-            binding.plainEditingFab.isVisible = !loading
+            binding?.run {
+                progress.isVisible = loading
+                noteWebview.isVisible = !loading
+                plainEditingFab.isVisible = !loading
+            }
         }
     }