Skip to content

Commit 943dbc4

Browse files
alperozturk96tobiasKaminsky
authored andcommitted
Better naming for alert dialog exported functions
Signed-off-by: alperozturk <[email protected]>
1 parent 4d7472f commit 943dbc4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/src/main/java/it/niedermann/owncloud/notes/main/MainActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ protected void onCreate(Bundle savedInstanceState) {
180180
runOnUiThread(() -> mainViewModel.postCurrentAccount(account));
181181
} catch (NextcloudFilesAppAccountNotFoundException e) {
182182
// Verbose log output for https://github.com/nextcloud/notes-android/issues/1256
183-
runOnUiThread(() -> showExceptionAlertDialog(e));
183+
runOnUiThread(() -> showAppAccountNotFoundAlertDialog(e));
184184
} catch (NoCurrentAccountSelectedException e) {
185185
runOnUiThread(() -> ExceptionDialogFragment.newInstance(e).show(getSupportFragmentManager(), ExceptionDialogFragment.class.getSimpleName()));
186186
}
@@ -325,7 +325,7 @@ public void onError(@NonNull Throwable t) {
325325
});
326326
}
327327

328-
private void showExceptionAlertDialog(NextcloudFilesAppAccountNotFoundException e) {
328+
private void showAppAccountNotFoundAlertDialog(NextcloudFilesAppAccountNotFoundException e) {
329329
final MaterialAlertDialogBuilder alertDialogBuilder = new MaterialAlertDialogBuilder(this)
330330
.setTitle(NextcloudFilesAppAccountNotFoundException.class.getSimpleName())
331331
.setMessage(R.string.backup)

app/src/main/java/it/niedermann/owncloud/notes/manageaccounts/ManageAccountsActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void onDelete(@NonNull Account accountToDelete) {
9595
public void onSuccess(Long unsynchronizedChangesCount) {
9696
runOnUiThread(() -> {
9797
if (unsynchronizedChangesCount > 0) {
98-
showDeleteAlertDialog(accountToDelete, unsynchronizedChangesCount);
98+
showRemoveAccountAlertDialog(accountToDelete, unsynchronizedChangesCount);
9999
} else {
100100
viewModel.deleteAccount(accountToDelete, ManageAccountsActivity.this);
101101
}
@@ -109,7 +109,7 @@ public void onError(@NonNull Throwable t) {
109109
});
110110
}
111111

112-
private void showDeleteAlertDialog(@NonNull Account accountToDelete, Long unsynchronizedChangesCount) {
112+
private void showRemoveAccountAlertDialog(@NonNull Account accountToDelete, Long unsynchronizedChangesCount) {
113113
final MaterialAlertDialogBuilder alertDialogBuilder = new DeleteAlertDialogBuilder(ManageAccountsActivity.this)
114114
.setTitle(getString(R.string.remove_account, accountToDelete.getUserName()))
115115
.setMessage(getResources().getQuantityString(R.plurals.remove_account_message, (int) unsynchronizedChangesCount.longValue(), accountToDelete.getAccountName(), unsynchronizedChangesCount))

0 commit comments

Comments
 (0)