Skip to content

Commit efaefaa

Browse files
committed
get rid of recreates
Signed-off-by: alperozturk <[email protected]>
1 parent 8189455 commit efaefaa

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

app/src/main/java/it/niedermann/owncloud/notes/share/NoteShareActivity.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -337,12 +337,11 @@ public void createPublicShareLink() {
337337
executorService.submit(() -> {
338338
final var result = repository.addShare(note, ShareType.PUBLIC_LINK, "", "false", "", 0, "");
339339
runOnUiThread(() -> {
340-
if (result instanceof ApiResult.Success<OcsResponse<CreateShareResponse>> successResponse) {
340+
if (result instanceof ApiResult.Success<OcsResponse<CreateShareResponse>> successResponse && binding.sharesList.getAdapter() instanceof ShareeListAdapter adapter) {
341341
DisplayUtils.showSnackMessage(NoteShareActivity.this, successResponse.getMessage());
342-
343342
note.setIsShared(true);
344343
repository.updateNote(note);
345-
runOnUiThread(NoteShareActivity.this::recreate);
344+
adapter.addShare(CreateShareResponseExtensionsKt.toOCShare(successResponse.getData().ocs.data));
346345
} else if (result instanceof ApiResult.Error errorResponse) {
347346
DisplayUtils.showSnackMessage(NoteShareActivity.this, errorResponse.getMessage());
348347
}
@@ -758,8 +757,7 @@ public void shareFileViaPublicShare(@Nullable Note note, @Nullable String passwo
758757
if (result instanceof ApiResult.Success<OcsResponse<CreateShareResponse>> successResponse &&
759758
binding.sharesList.getAdapter() instanceof ShareeListAdapter adapter) {
760759
adapter.addShare(CreateShareResponseExtensionsKt.toOCShare(successResponse.getData().ocs.data));
761-
} else if (ApiResultKt.isError(result)) {
762-
ApiResult.Error error = (ApiResult.Error) result;
760+
} else if (result instanceof ApiResult.Error error) {
763761
DisplayUtils.showSnackMessage(NoteShareActivity.this, error.getMessage());
764762
}
765763
});

0 commit comments

Comments
 (0)