fix: clear appconfig cache in reverse-cookie self-test

Signed-off-by: Robin Appelman <robin@icewind.nl>

Author: icewind1991

lib/Controller/TestController.php

@@ -15,6 +15,7 @@
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataDisplayResponse;
 use OCP\AppFramework\Http\DataResponse;
+use OCP\IAppConfig;
 use OCP\IConfig;
 use OCP\IRequest;
 
@@ -25,7 +26,7 @@ class TestController extends Controller {
 
 	public function __construct(
 		IRequest $request,
-		IConfig $config,
+		IAppConfig $config,
 		IQueue $queue,
 		IAppManager $appManager,
 	) {
@@ -41,7 +42,14 @@ public function __construct(
 	 * @NoCSRFRequired
 	 */
 	public function cookie(): DataResponse {
-		return new DataResponse((int)$this->config->getAppValue('notify_push', 'cookie', '0'));
+		// starting with 32, the app config does some internal caching
+		// that interferes with the quick set+get from this test.
+		// unfortunately the api to clear the cache is 29+ only, and we still support 27
+		if (method_exists($this->config, 'clearCache')) {
+			/** @psalm-suppress UndefinedInterfaceMethod */
+			$this->config->clearCache();
+		}
+		return new DataResponse((int)$this->config->getValue('notify_push', 'cookie', '0'));
 	}
 
 	/**

lib/SelfTest.php

@@ -13,6 +13,7 @@
 use OCA\NotifyPush\Queue\RedisQueue;
 use OCP\App\IAppManager;
 use OCP\Http\Client\IClientService;
+use OCP\IAppConfig;
 use OCP\IConfig;
 use OCP\IDBConnection;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -28,6 +29,7 @@ class SelfTest {
 	public function __construct(
 		IClientService $clientService,
 		private IConfig $config,
+		private IAppConfig $appConfig,
 		private IQueue $queue,
 		private IDBConnection $connection,
 		private IAppManager $appManager,
@@ -55,7 +57,7 @@ public function test(string $server, OutputInterface $output, bool $ignoreProxyE
 		}
 
 		$this->queue->push('notify_test_cookie', $this->cookie);
-		$this->config->setAppValue('notify_push', 'cookie', (string)$this->cookie);
+		$this->appConfig->setValue('notify_push', 'cookie', (string)$this->cookie);
 
 		try {
 			$retrievedCookie = (int)$this->client->get($server . '/test/cookie', ['nextcloud' => ['allow_local_address' => true], 'verify' => false])->getBody();