fix: Introduce internal require_api_key setting

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Author: marcelklehr

.github/workflows/cluster-faces-test.yml

@@ -163,6 +163,8 @@ jobs:
         run: |
           ./occ config:app:set --lazy --value ${{ matrix.pure-js-mode }} recognize tensorflow.purejs
           ./occ config:app:set --value true recognize faces.enabled
+          # Don't force API key usage to allow tests to run
+          ./occ config:app:set --value false recognize require_api_key
           # only use one core. GH actions has 2
           ./occ config:app:set --value 1 recognize tensorflow.cores
 

lib/Dav/Faces/PropFindPlugin.php

@@ -15,6 +15,7 @@
 use OCA\Recognize\Db\FaceDetectionWithTitle;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Db\MultipleObjectsReturnedException;
+use OCP\AppFramework\Services\IAppConfig;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\DB\Exception;
 use OCP\Files\DavUtil;
@@ -47,6 +48,7 @@ public function __construct(
 		private ICrypto $crypto,
 		private LoggerInterface $logger,
 		private ITimeFactory $timeFactory,
+		private IAppConfig $appConfig,
 	) {
 	}
 
@@ -130,6 +132,9 @@ public function beforeMethod(RequestInterface $request, ResponseInterface $respo
 		if (!str_starts_with($request->getPath(), 'recognize')) {
 			return;
 		}
+		if ($this->appConfig->getAppValueString('require_api_key', 'true') !== 'true') {
+			return;
+		}
 		$key = $request->getHeader('X-Recognize-Api-Key');
 		if ($key === null) {
 			throw new Forbidden('You must provide a valid X-Recognize-Api-Key');