fix(psalm): undefined interface methods

elzody · elzody · commit 8e4a5cc636ef · 2026-01-27T21:29:39.000-05:00
Signed-off-by: Elizabeth Danzberger &lt;elizabeth@elzody.dev&gt;
diff --git a/lib/Controller/DocumentController.php b/lib/Controller/DocumentController.php
@@ -256,7 +256,7 @@ public function remote(string $shareToken, string $remoteServer, string $remoteS
 			}
 
 			$node = $share->getNode();
-			if ($filePath !== null) {
+			if ($filePath !== null && $node instanceof Folder) {
 				$node = $node->get($filePath);
 			}
 
@@ -484,10 +484,8 @@ private function getFileForShare(IShare $share, ?int $fileId, ?string $path = nu
 			throw new NotFoundException();
 		}
 
-		if ($path !== null) {
-			$node = $node->get($path);
-		} else {
-			$node = $node->getFirstNodeById($fileId);
+		if ($node instanceof Folder) {
+			$node = ($path !== null) ? $node->get($path) : $node->getFirstNodeById($fileId);
 		}
 
 		if ($node instanceof File) {

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ public function remote(string $shareToken, string $remoteServer, string $remoteS`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`$node = $share->getNode();`
`259`		`- if ($filePath !== null) {`
	`259`	`+ if ($filePath !== null && $node instanceof Folder) {`
`260`	`260`	`$node = $node->get($filePath);`
`261`	`261`	`}`
`262`	`262`
`@@ -484,10 +484,8 @@ private function getFileForShare(IShare $share, ?int $fileId, ?string $path = nu`
`484`	`484`	`throw new NotFoundException();`
`485`	`485`	`}`
`486`	`486`
`487`		`- if ($path !== null) {`
`488`		`- $node = $node->get($path);`
`489`		`- } else {`
`490`		`- $node = $node->getFirstNodeById($fileId);`
	`487`	`+ if ($node instanceof Folder) {`
	`488`	`+ $node = ($path !== null) ? $node->get($path) : $node->getFirstNodeById($fileId);`
`491`	`489`	`}`
`492`	`490`
`493`	`491`	`if ($node instanceof File) {`