Merge pull request #57583 from nextcloud/chore/drop-whats-new

chore: drop legacy `WhatsNew`

Author: susnux

apps/updatenotification/lib/UpdateChecker.php

@@ -9,15 +9,13 @@
  */
 namespace OCA\UpdateNotification;
 
-use OC\Updater\ChangesCheck;
 use OC\Updater\VersionCheck;
 use OCP\AppFramework\Services\IInitialState;
 
 class UpdateChecker {
 
 	public function __construct(
 		private VersionCheck $updater,
-		private ChangesCheck $changesCheck,
 		private IInitialState $initialState,
 	) {
 	}
@@ -41,13 +39,6 @@ public function getUpdateState(): array {
 			if (strpos($data['url'], 'https://') === 0) {
 				$result['downloadLink'] = $data['url'];
 			}
-			if (strpos($data['changes'], 'https://') === 0) {
-				try {
-					$result['changes'] = $this->changesCheck->check($data['changes'], $data['version']);
-				} catch (\Exception $e) {
-					// no info, not a problem
-				}
-			}
 
 			return $result;
 		}

apps/updatenotification/tests/UpdateCheckerTest.php

@@ -8,7 +8,6 @@
  */
 namespace OCA\UpdateNotification\Tests;
 
-use OC\Updater\ChangesCheck;
 use OC\Updater\VersionCheck;
 use OCA\UpdateNotification\UpdateChecker;
 use OCP\AppFramework\Services\IInitialState;
@@ -17,7 +16,6 @@
 
 class UpdateCheckerTest extends TestCase {
 
-	private ChangesCheck&MockObject $changesChecker;
 	private VersionCheck&MockObject $updater;
 	private IInitialState&MockObject $initialState;
 	private UpdateChecker $updateChecker;
@@ -26,11 +24,9 @@ protected function setUp(): void {
 		parent::setUp();
 
 		$this->updater = $this->createMock(VersionCheck::class);
-		$this->changesChecker = $this->createMock(ChangesCheck::class);
 		$this->initialState = $this->createMock(IInitialState::class);
 		$this->updateChecker = new UpdateChecker(
 			$this->updater,
-			$this->changesChecker,
 			$this->initialState,
 		);
 	}
@@ -85,15 +81,10 @@ public function testGetUpdateStateWithUpdateAndValidLink(): void {
 				'versionstring' => 'Nextcloud 1.2.3',
 				'web' => 'https://docs.nextcloud.com/myUrl',
 				'url' => 'https://downloads.nextcloud.org/server',
-				'changes' => 'https://updates.nextcloud.com/changelog_server/?version=123.0.0',
 				'autoupdater' => '1',
 				'eol' => '0',
 			]);
 
-		$this->changesChecker->expects($this->once())
-			->method('check')
-			->willReturn($changes);
-
 		$expected = [
 			'updateAvailable' => true,
 			'updateVersion' => '1.2.3',
@@ -102,7 +93,6 @@ public function testGetUpdateStateWithUpdateAndValidLink(): void {
 			'versionIsEol' => false,
 			'updateLink' => 'https://docs.nextcloud.com/myUrl',
 			'downloadLink' => 'https://downloads.nextcloud.org/server',
-			'changes' => $changes,
 		];
 		$this->assertSame($expected, $this->updateChecker->getUpdateState());
 	}
@@ -126,7 +116,6 @@ public function testSetInitialState(): void {
 				'versionstring' => 'Nextcloud 1.2.3',
 				'web' => 'https://docs.nextcloud.com/myUrl',
 				'url' => 'https://downloads.nextcloud.org/server',
-				'changes' => 'https://updates.nextcloud.com/changelog_server/?version=123.0.0',
 				'autoupdater' => '1',
 				'eol' => '0',
 			]);

build/psalm-baseline.xml

@@ -3215,12 +3215,6 @@
 		)]]></code>
     </DeprecatedMethod>
   </file>
-  <file src="core/Controller/WhatsNewController.php">
-    <DeprecatedMethod>
-      <code><![CDATA[getUserValue]]></code>
-      <code><![CDATA[setUserValue]]></code>
-    </DeprecatedMethod>
-  </file>
   <file src="core/Middleware/TwoFactorMiddleware.php">
     <DeprecatedInterface>
       <code><![CDATA[private]]></code>

core/Controller/WhatsNewController.php

@@ -99,14 +99,6 @@ public function handle(Event $event): void {
 			true
 		);
 
-		$event->addMissingIndex(
-			'whats_new',
-			'version',
-			['version'],
-			[],
-			true
-		);
-
 		$event->addMissingIndex(
 			'cards',
 			'cards_abiduri',

core/Listener/AddMissingIndicesListener.php

@@ -0,0 +1,23 @@
+<?php
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OC\Core\Migrations;
+
+use OCP\DB\ISchemaWrapper;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version34000Date20260122120000 extends SimpleMigrationStep {
+	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+		/** @var ISchemaWrapper $schema */
+		$schema = $schemaClosure();
+		if ($schema->hasTable('whats_new')) {
+			$schema->dropTable('whats_new');
+		}
+		return $schema;
+	}
+}