fixup! fixup! feat(snowflake): Use string as type for snowflake ids

Author: CarlSchwan

lib/private/DB/Snowflake/SnowflakeGenerator.php

@@ -172,9 +172,13 @@ public function parseId(string $id): array {
 	 * @internal For unit tests only.
 	 */
 	public function getCurrentMillisecond(): string {
-		$time = microtime();
-		$time = explode(' ', $time);
-		return $time[1] . floor((float)$time[0] * 1000);
+		if ($this->is32BitsSystem()) {
+			$time = microtime();
+			$time = explode(' ', $time);
+			return $time[1] . str_pad((string)floor((float)$time[0] * 1000), 3, '0', STR_PAD_LEFT);
+		} else {
+			return (string)(floor(microtime(true) * 1000));
+		}
 	}
 
 	/**
@@ -183,6 +187,10 @@ public function getCurrentMillisecond(): string {
 	 */
 	public function setStartTimeStamp(int $second): self {
 		if ($this->is32BitsSystem()) {
+			if (!function_exists('gmp_init')) {
+				throw new \RuntimeException('gmp is a required extension to run on 32 bit system.');
+			}
+
 			$missTime = gmp_sub($this->getCurrentMillisecond(), gmp_mul($second, 1000));
 
 			if (gmp_cmp($missTime, 0) < 0) {
@@ -202,7 +210,7 @@ public function setStartTimeStamp(int $second): self {
 			$missTime = (int)$this->getCurrentMillisecond() - $second * 1000;
 
 			if ($missTime < 0) {
-				throw new \InvalidArgumentException('The start time cannot be greater than the current time');
+				throw new \InvalidArgumentException('The start time cannot be greater than the current time. starttime=' . $second * 1000 . ' current=' . $this->getCurrentMillisecond());
 			}
 
 			$maxTimeDiff = -1 ^ (-1 << self::MAX_TIMESTAMP_LENGTH);

tests/lib/DB/SnowflakeTest.php

@@ -23,6 +23,10 @@ class SnowflakeTest extends TestCase {
 	#[TestWith(data: [false, true, 60 * 60 * 24 * 365 * 10])] // ~10 years
 	#[TestWith(data: [false, false, 60 * 60 * 24 * 365 * 10])]
 	public function testLayout(bool $isCLIExpected, bool $is32BitsSystem, int $timeDiff): void {
+		if (!$is32BitsSystem && PHP_INT_SIZE < 8) {
+			$this->markTestSkipped('Unable to run 64 bits code on 32 bits system.');
+		}
+
 		$baseTimestamp = strtotime('2025-01-01');
 		$resolver = $this->createMock(NextcloudSequenceResolver::class);
 		$resolver->method('isAvailable')->willReturn(true);