Skip to content

Commit 183136d

Browse files
chore: Fix comments and formatting in Plugin.php
Signed-off-by: Josh <[email protected]>
1 parent b872208 commit 183136d

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

apps/files_versions/lib/Sabre/Plugin.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,14 @@ public function afterGet(RequestInterface $request, ResponseInterface $response)
8383
/**
8484
* WebDAV PROPFIND event handler for versioned files.
8585
*
86-
* Provides read-only access to version-related information, upon request, if the
86+
* Provides read-only access to version-related information if the
8787
* current node is a VersionFile.
8888
*/
8989
public function propFind(PropFind $propFind, INode $node): void {
9090
if (!($node instanceof VersionFile)) {
9191
return;
9292
}
93-
93+
9494
$propFind->handle(
9595
self::VERSION_LABEL,
9696
fn () => $node->getMetadataValue(self::LABEL)
@@ -108,15 +108,15 @@ public function propFind(PropFind $propFind, INode $node): void {
108108
/**
109109
* WebDAV PROPPATCH event handler for versioned files.
110110
*
111-
* Updates version related properties (such as the label) on VersionFile nodes.
111+
* Updates version related properties on VersionFile nodes.
112112
*/
113113
public function propPatch(string $path, PropPatch $propPatch): void {
114114
$node = $this->server->tree->getNodeForPath($path);
115115

116116
if (!($node instanceof VersionFile)) {
117117
return;
118118
}
119-
119+
120120
$propPatch->handle(
121121
self::VERSION_LABEL,
122122
fn (string $label) => $node->setMetadataValue(self::LABEL, $label)
@@ -129,11 +129,11 @@ public function propPatch(string $path, PropPatch $propPatch): void {
129129
* Sends both 'filename' (legacy quoted) and 'filename*' (UTF-8 encoded) per RFC 6266,
130130
* except for known quirky agents known to mishandle the `filename*`, which only get `filename`.
131131
*
132-
* Note: The quoting/escaping should strictly follow RFC 6266 and RFC 5987.
132+
* Note: The quoting/escaping should strictly follow RFC 6266 and RFC 5987.
133133
*
134134
* TODO: Currently uses rawurlencode($filename) for both parameters, which is wrong: filename= should be plain
135135
* quoted ASCII (with necessary escaping), while filename* should be UTF-8 percent-encoded.
136-
* TODO: This logic appears elsewhere (sometimes with different quoting/filename handling) and could benefit
136+
* TODO: This logic appears elsewhere (sometimes with different quoting/filename handling) and could benefit
137137
* from a shared utility function. See Symfony example:
138138
* - https://github.com/symfony/symfony/blob/175775eb21508becf7e7a16d65959488e522c39a/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php#L146-L155
139139
* - https://github.com/symfony/symfony/blob/175775eb21508becf7e7a16d65959488e522c39a/src/Symfony/Component/HttpFoundation/HeaderUtils.php#L152-L165
@@ -149,12 +149,12 @@ private function addContentDispositionHeader(ResponseInterface $response, string
149149
$response->addHeader(
150150
'Content-Disposition',
151151
'attachment; filename="' . rawurlencode($filename) . '"; filename*=UTF-8\'\'' . rawurlencode($filename)
152-
);
152+
);
153153
} else {
154154
// Quirky clients that choke on `filename*`: only send `filename=`
155155
$response->addHeader(
156156
'Content-Disposition',
157157
'attachment; filename="' . rawurlencode($filename) . '"');
158-
}
158+
}
159159
}
160160
}

0 commit comments

Comments
 (0)