Skip to content

Commit 1e17a9f

Browse files
artongesusnux
authored andcommitted
refactor(user_ldap): Migrate to Vue3
Signed-off-by: Louis Chmn <[email protected]>
1 parent 4f9efc4 commit 1e17a9f

File tree

8 files changed

+21
-26
lines changed

8 files changed

+21
-26
lines changed

apps/user_ldap/lib/AppInfo/Application.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,10 @@
4545
use Psr\Log\LoggerInterface;
4646

4747
class Application extends App implements IBootstrap {
48+
public const APP_ID = 'user_ldap';
49+
4850
public function __construct() {
49-
parent::__construct('user_ldap');
51+
parent::__construct(self::APP_ID);
5052
$container = $this->getContainer();
5153

5254
/**

apps/user_ldap/lib/Settings/Admin.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
*/
77
namespace OCA\User_LDAP\Settings;
88

9+
use OCA\User_LDAP\AppInfo\Application;
910
use OCA\User_LDAP\Configuration;
1011
use OCA\User_LDAP\Helper;
1112
use OCP\AppFramework\Http\TemplateResponse;
@@ -59,7 +60,9 @@ public function getForm(): TemplateResponse {
5960
$this->initialState->provideInitialState('ldapConfigs', $ldapConfigs);
6061
$this->initialState->provideInitialState('ldapModuleInstalled', function_exists('ldap_connect'));
6162

62-
return new TemplateResponse('user_ldap', 'settings', $parameters);
63+
\OCP\Util::addStyle(Application::APP_ID, 'settings-admin');
64+
\OCP\Util::addScript(Application::APP_ID, 'settings-admin');
65+
return new TemplateResponse(Application::APP_ID, 'settings', $parameters);
6366
}
6467

6568
public function getSection(): string {

apps/user_ldap/src/main.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/**
2+
* SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
3+
* SPDX-License-Identifier: AGPL-3.0-or-later
4+
*/
5+
import { createApp } from 'vue'
6+
import LDAPSettingsApp from './LDAPSettingsApp.vue'
7+
import { pinia } from './store/index.ts'
8+
9+
const app = createApp(LDAPSettingsApp)
10+
app.use(pinia)
11+
app.mount('#content-ldap-settings')

apps/user_ldap/templates/settings.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* SPDX-License-Identifier: AGPL-3.0-only
77
*/
88

9-
\OCP\Util::addScript('user_ldap', 'main', 'core');
109
?>
1110

1211
<div id="content-ldap-settings"></div>

build/frontend-legacy/webpack.modules.cjs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ module.exports = {
100100
updatenotification: path.join(__dirname, 'apps/updatenotification/src', 'updatenotification.js'),
101101
'update-notification-legacy': path.join(__dirname, 'apps/updatenotification/src', 'update-notification-legacy.ts'),
102102
},
103-
user_ldap: {
104-
main: path.join(__dirname, 'apps/user_ldap/src', 'main.js'),
105-
},
106103
user_status: {
107104
menu: path.join(__dirname, 'apps/user_status/src', 'menu.js'),
108105
},

build/frontend/vite.config.mts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ const modules = {
2424
twofactor_backupcodes: {
2525
'settings-personal': resolve(import.meta.dirname, 'apps/twofactor_backupcodes/src', 'settings-personal.ts'),
2626
},
27+
user_ldap: {
28+
'settings-admin': resolve(import.meta.dirname, 'apps/user_ldap/src', 'settings-admin.ts'),
29+
},
2730
}
2831

2932
// convert modules to modules entries prefied with the app id

0 commit comments

Comments
 (0)