refactor: consolidate OC.Settings

1. Remove unused legacy parts (no code match in the whole github
organization).
2. Consolidate `OC.Settings` in `core/src/OC` for consistency.

Signed-off-by: Ferdinand Thiessen <[email protected]>

Author: susnux

apps/settings/css/settings.scss

@@ -239,75 +239,6 @@ select {
 	}
 }
 
-.federation-menu {
-	position: relative;
-	cursor: pointer;
-	width: var(--default-clickable-area);
-	height: var(--default-clickable-area);
-	padding: calc(2 * var(--default-grid-baseline));
-	margin: 0;
-	background: none;
-	border: none;
-
-	&:hover,
-	&:focus {
-		background-color: var(--color-background-hover);
-		border-radius: var(--border-radius-element);
-
-		.icon-federation-menu {
-			opacity: 0.8;
-		}
-	}
-
-	.icon-federation-menu {
-		padding-inline-start: 16px;
-		background-size: 16px;
-		background-position: left center;
-		opacity: .3;
-		cursor: inherit;
-
-		.icon-triangle-s {
-			display: inline-block;
-			vertical-align: middle;
-			cursor: inherit;
-		}
-	}
-
-	.federationScopeMenu {
-		top: var(--default-clickable-area);
-
-		&.popovermenu {
-			.menuitem {
-				// override h3 heading font size
-				font-size: 12.8px;
-				line-height: 1.6em;
-
-				.menuitem-text-detail {
-					opacity: .75;
-				}
-
-				&.active {
-					box-shadow: inset 2px 0 var(--color-primary-element);
-
-					.menuitem-text {
-						font-weight: bold;
-					}
-				}
-
-				&.disabled {
-					opacity: .5;
-
-					cursor: default;
-
-					* {
-						cursor: default;
-					}
-				}
-			}
-		}
-	}
-}
-
 .clientsbox img {
 	height: 60px;
 }

apps/settings/js/templates.js

@@ -10,9 +10,5 @@ __webpack_nonce__ = getCSPNonce()
 
 Vue.prototype.t = t
 
-// Not used here but required for legacy templates
-window.OC = window.OC || {}
-window.OC.Settings = window.OC.Settings || {}
-
 const View = Vue.extend(ArtificialIntelligence)
 new View().$mount('#ai-settings')

apps/settings/js/templates/federationscopemenu.handlebars

@@ -13,10 +13,6 @@ __webpack_nonce__ = getCSPNonce()
 
 Vue.prototype.t = t
 
-// Not used here but required for legacy templates
-window.OC = window.OC || {}
-window.OC.Settings = window.OC.Settings || {}
-
 store.replaceState(loadState('settings', 'mandatory2FAState'))
 
 const View = Vue.extend(AdminTwoFactor)

apps/settings/js/usersettings.js

@@ -4,9 +4,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-script('settings', [
-	'vue-settings-admin-ai',
-]);
+\OCP\Util::addScript('settings', 'vue-settings-admin-ai');
 ?>
 
 <div id="ai-settings">

apps/settings/src/apps.js

@@ -7,9 +7,7 @@
 /** @var \OCP\IL10N $l */
 /** @var array $_ */
 
-script('settings', [
-	'vue-settings-admin-basic-settings',
-]);
+\OCP\Util::addScript('settings', 'vue-settings-admin-basic-settings');
 ?>
 
 <div id="vue-admin-background-job"></div>

apps/settings/src/main-admin-ai.js

@@ -5,9 +5,7 @@
  */
 
 style('settings', 'settings');
-\OCP\Util::addScript('settings', 'settings', 'core');
 \OCP\Util::addScript('settings', 'legacy-admin');
-
 ?>
 
 <div id="app-navigation">