Skip to content

Commit 2a0a6b6

Browse files
authored
Merge pull request #50553 from nextcloud/perf/check-node-type
perf(files): Check node type property instead of instance
2 parents c89e139 + ac2a943 commit 2a0a6b6

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

apps/files/src/views/folderTree.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import type { TreeNode } from '../services/FolderTree.ts'
77

88
import PQueue from 'p-queue'
9-
import { Folder, Node, View, getNavigation } from '@nextcloud/files'
9+
import { FileType, Folder, Node, View, getNavigation } from '@nextcloud/files'
1010
import { translate as t } from '@nextcloud/l10n'
1111
import { emit, subscribe } from '@nextcloud/event-bus'
1212
import { isSamePath } from '@nextcloud/paths'
@@ -99,21 +99,21 @@ const removeFolderViewSource = (source: string) => {
9999
}
100100

101101
const onCreateNode = (node: Node) => {
102-
if (!(node instanceof Folder)) {
102+
if (node.type !== FileType.Folder) {
103103
return
104104
}
105105
registerNodeView(node)
106106
}
107107

108108
const onDeleteNode = (node: Node) => {
109-
if (!(node instanceof Folder)) {
109+
if (node.type !== FileType.Folder) {
110110
return
111111
}
112112
removeFolderView(node)
113113
}
114114

115115
const onMoveNode = ({ node, oldSource }) => {
116-
if (!(node instanceof Folder)) {
116+
if (node.type !== FileType.Folder) {
117117
return
118118
}
119119
removeFolderViewSource(oldSource)

dist/files-init.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-init.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)