refactor(files_sharing): apply DRY in MountProvider

Signed-off-by: Salvatore Martire <[email protected]>

Author: salmart-dev

apps/files_sharing/lib/MountProvider.php

@@ -79,10 +79,8 @@ public function getMountsForUser(IUser $user, IStorageFactory $loader) {
 		$newMaxValidatedShare = $maxValidatedShare;
 
 		foreach ($superShares as $share) {
+			[$parentShare, $groupedShares] = $share;
 			try {
-				/** @var IShare $parentShare */
-				$parentShare = $share[0];
-
 				if ($parentShare->getStatus() !== IShare::STATUS_ACCEPTED
 					&& ($parentShare->getShareType() === IShare::TYPE_GROUP
 						|| $parentShare->getShareType() === IShare::TYPE_USERGROUP
@@ -92,7 +90,7 @@ public function getMountsForUser(IUser $user, IStorageFactory $loader) {
 
 				$owner = $parentShare->getShareOwner();
 				if (!isset($ownerViews[$owner])) {
-					$ownerViews[$owner] = new View('/' . $parentShare->getShareOwner() . '/files');
+					$ownerViews[$owner] = new View('/' . $owner . '/files');
 				}
 				$shareId = (int)$parentShare->getId();
 				$mount = new SharedMount(
@@ -103,7 +101,7 @@ public function getMountsForUser(IUser $user, IStorageFactory $loader) {
 						// parent share
 						'superShare' => $parentShare,
 						// children/component of the superShare
-						'groupedShares' => $share[1],
+						'groupedShares' => $groupedShares,
 						'ownerView' => $ownerViews[$owner],
 						'sharingDisabledForUser' => $sharingDisabledForUser
 					],

build/psalm-baseline.xml

@@ -1685,11 +1685,11 @@
   </file>
   <file src="apps/files_sharing/lib/MountProvider.php">
     <InternalClass>
-      <code><![CDATA[new View('/' . $parentShare->getShareOwner() . '/files')]]></code>
+      <code><![CDATA[new View('/' . $owner . '/files')]]></code>
       <code><![CDATA[new View('/' . $userId . '/files')]]></code>
     </InternalClass>
     <InternalMethod>
-      <code><![CDATA[new View('/' . $parentShare->getShareOwner() . '/files')]]></code>
+      <code><![CDATA[new View('/' . $owner . '/files')]]></code>
       <code><![CDATA[new View('/' . $userId . '/files')]]></code>
     </InternalMethod>
   </file>