Merge pull request #51477 from nextcloud/fix/reset-phone-number

fix(profile): allow to unset phone number

Author: susnux

apps/settings/src/components/PersonalInfo/PhoneSection.vue

@@ -39,6 +39,10 @@ export default {
 
 	methods: {
 		onValidate(value) {
+			if (value === '') {
+				return true
+			}
+
 			if (defaultPhoneRegion) {
 				return isValidPhoneNumber(value, defaultPhoneRegion)
 			}

cypress/e2e/settings/personal-info.cy.ts

@@ -336,6 +336,40 @@ describe('Settings: Change personal information', { testIsolation: true }, () =>
 		cy.get('a[href="tel:+498972101099701"]').should('be.visible')
 	})
 
+	it('Can set phone number with phone region', () => {
+		cy.contains('label', 'Phone number').scrollIntoView()
+		inputForLabel('Phone number').type('{selectAll}0 40 428990')
+		inputForLabel('Phone number').should('have.attr', 'class').and('contain', '--error')
+
+		cy.runOccCommand('config:system:set default_phone_region --value DE')
+		cy.reload()
+
+		cy.contains('label', 'Phone number').scrollIntoView()
+		inputForLabel('Phone number').type('{selectAll}0 40 428990')
+		handlePasswordConfirmation(user.password)
+
+		cy.wait('@submitSetting')
+		cy.reload()
+		inputForLabel('Phone number').should('have.value', '+4940428990')
+	})
+
+	it('Can reset phone number', () => {
+		cy.contains('label', 'Phone number').scrollIntoView()
+		inputForLabel('Phone number').type('{selectAll}+49 40 428990')
+		handlePasswordConfirmation(user.password)
+
+		cy.wait('@submitSetting')
+		cy.reload()
+		inputForLabel('Phone number').should('have.value', '+4940428990')
+
+		inputForLabel('Phone number').clear()
+		handlePasswordConfirmation(user.password)
+
+		cy.wait('@submitSetting')
+		cy.reload()
+		inputForLabel('Phone number').should('have.value', '')
+	})
+
 	it('Can set Website and change its visibility', () => {
 		cy.contains('label', 'Website').scrollIntoView()
 		// Check invalid input

dist/settings-vue-settings-personal-info.js

@@ -171,7 +171,7 @@
     "karma-spec-reporter": "^0.0.36",
     "karma-viewport": "^1.0.9",
     "mime": "^4.0.6",
-    "puppeteer": "^24.1.1",
+    "puppeteer": "^24.4.0",
     "raw-loader": "^4.0.2",
     "regextras": "^0.8.0",
     "sass": "^1.81.0",

dist/settings-vue-settings-personal-info.js.map

@@ -18,8 +18,11 @@
  * preprocessor, which is needed to be able to debug tests properly in a browser.
  */
 
+const { existsSync } = require('node:fs');
+
 if (!process.env.CHROMIUM_BIN) {
-	process.env.CHROMIUM_BIN = require('puppeteer').executablePath()
+	const chrome = require('puppeteer').executablePath()
+	process.env.CHROMIUM_BIN = chrome
 }
 
 /* jshint node: true */
@@ -243,14 +246,19 @@ module.exports = function(config) {
 		// - PhantomJS
 		// - IE (only Windows; has to be installed with `npm install karma-ie-launcher`)
 		// use PhantomJS_debug for extra local debug
-		browsers: ['ChromiumHeadless'],
+		browsers: ['Chrome_without_sandbox'],
 
 		// you can define custom flags
 		customLaunchers: {
 			PhantomJS_debug: {
 				base: 'PhantomJS',
 				debug: true
-			}
+			},
+			// fix CI
+			Chrome_without_sandbox: {
+				base: 'ChromiumHeadless',
+				flags: ['--no-sandbox'],
+			},
 		},
 
 		// If browser does not capture in given timeout [ms], kill it