|
| 1 | +<?php |
| 2 | + |
| 3 | +declare(strict_types=1); |
| 4 | + |
| 5 | +/** |
| 6 | + * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors |
| 7 | + * SPDX-License-Identifier: AGPL-3.0-or-later |
| 8 | + */ |
| 9 | + |
| 10 | +namespace OC\Core\Migrations; |
| 11 | + |
| 12 | +use Closure; |
| 13 | +use OCP\DB\ISchemaWrapper; |
| 14 | +use OCP\IDBConnection; |
| 15 | +use OCP\Migration\IOutput; |
| 16 | +use OCP\Migration\SimpleMigrationStep; |
| 17 | +use Override; |
| 18 | + |
| 19 | +/** |
| 20 | + * Make sure vcategory entries are unique per user and type |
| 21 | + * This migration will clean up existing duplicates |
| 22 | + * and add a unique constraint to prevent future duplicates. |
| 23 | + */ |
| 24 | +class Version32000Date20250731062008 extends SimpleMigrationStep { |
| 25 | + public function __construct( |
| 26 | + private IDBConnection $connection, |
| 27 | + ) { |
| 28 | + } |
| 29 | + |
| 30 | + /** |
| 31 | + * @param IOutput $output |
| 32 | + * @param Closure(): ISchemaWrapper $schemaClosure |
| 33 | + * @param array $options |
| 34 | + */ |
| 35 | + #[Override] |
| 36 | + public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void { |
| 37 | + // Clean up duplicate categories before adding unique constraint |
| 38 | + $this->cleanupDuplicateCategories($output); |
| 39 | + } |
| 40 | + |
| 41 | + /** |
| 42 | + * @param IOutput $output |
| 43 | + * @param Closure(): ISchemaWrapper $schemaClosure |
| 44 | + * @param array $options |
| 45 | + * @return null|ISchemaWrapper |
| 46 | + */ |
| 47 | + #[Override] |
| 48 | + public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { |
| 49 | + return null; |
| 50 | + } |
| 51 | + |
| 52 | + /** |
| 53 | + * @param IOutput $output |
| 54 | + * @param Closure(): ISchemaWrapper $schemaClosure |
| 55 | + * @param array $options |
| 56 | + */ |
| 57 | + #[Override] |
| 58 | + public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void { |
| 59 | + } |
| 60 | + |
| 61 | + /** |
| 62 | + * Clean up duplicate categories |
| 63 | + */ |
| 64 | + private function cleanupDuplicateCategories(IOutput $output) { |
| 65 | + $output->info('Starting cleanup of duplicate vcategory records...'); |
| 66 | + |
| 67 | + // Find all categories, ordered to identify duplicates |
| 68 | + $qb = $this->connection->getQueryBuilder(); |
| 69 | + $qb->select('id', 'uid', 'type', 'category') |
| 70 | + ->from('vcategory') |
| 71 | + ->orderBy('uid') |
| 72 | + ->addOrderBy('type') |
| 73 | + ->addOrderBy('category') |
| 74 | + ->addOrderBy('id'); |
| 75 | + |
| 76 | + $result = $qb->executeQuery(); |
| 77 | + |
| 78 | + $seen = []; |
| 79 | + $duplicateCount = 0; |
| 80 | + |
| 81 | + while ($category = $result->fetch()) { |
| 82 | + $key = $category['uid'] . '|' . $category['type'] . '|' . $category['category']; |
| 83 | + $categoryId = (int)$category['id']; |
| 84 | + |
| 85 | + if (!isset($seen[$key])) { |
| 86 | + // First occurrence - keep this one |
| 87 | + $seen[$key] = $categoryId; |
| 88 | + continue; |
| 89 | + } |
| 90 | + |
| 91 | + // Duplicate found |
| 92 | + $keepId = $seen[$key]; |
| 93 | + $duplicateCount++; |
| 94 | + |
| 95 | + $output->info("Found duplicate: keeping ID $keepId, removing ID $categoryId"); |
| 96 | + |
| 97 | + // Update object references |
| 98 | + $updateQb = $this->connection->getQueryBuilder(); |
| 99 | + $updateQb->update('vcategory_to_object') |
| 100 | + ->set('categoryid', $updateQb->createNamedParameter($keepId)) |
| 101 | + ->where($updateQb->expr()->eq('categoryid', $updateQb->createNamedParameter($categoryId))); |
| 102 | + |
| 103 | + $affectedRows = $updateQb->executeStatement(); |
| 104 | + if ($affectedRows > 0) { |
| 105 | + $output->info(" - Updated $affectedRows object references from category $categoryId to $keepId"); |
| 106 | + } |
| 107 | + |
| 108 | + // Remove duplicate category record |
| 109 | + $deleteQb = $this->connection->getQueryBuilder(); |
| 110 | + $deleteQb->delete('vcategory') |
| 111 | + ->where($deleteQb->expr()->eq('id', $deleteQb->createNamedParameter($categoryId))); |
| 112 | + |
| 113 | + $deleteQb->executeStatement(); |
| 114 | + $output->info(" - Deleted duplicate category record ID $categoryId"); |
| 115 | + |
| 116 | + } |
| 117 | + |
| 118 | + $result->closeCursor(); |
| 119 | + |
| 120 | + if ($duplicateCount === 0) { |
| 121 | + $output->info('No duplicate categories found'); |
| 122 | + } else { |
| 123 | + $output->info("Duplicate cleanup completed - processed $duplicateCount duplicates"); |
| 124 | + } |
| 125 | + } |
| 126 | +} |
0 commit comments