fix(FileSequence): Do not cache temp dir but use ITempManager directly

marcelklehr · web-flow · commit 53759d5d6a0e · 2025-12-15T15:03:29.000+01:00
Signed-off-by: Marcel Klehr &lt;mklehr@gmx.net&gt;
diff --git a/lib/private/Snowflake/FileSequence.php b/lib/private/Snowflake/FileSequence.php
@@ -20,12 +20,9 @@ class FileSequence implements ISequence {
 	/** Delete sequences after SEQUENCE_TTL seconds **/
 	private const SEQUENCE_TTL = 30;
 
-	private string $workDir;
-
 	public function __construct(
-		ITempManager $tempManager,
+		private ITempManager $tempManager,
 	) {
-		$this->workDir = $tempManager->getTemporaryFolder('.snowflakes');
 	}
 
 	#[Override]
@@ -84,6 +81,6 @@ public function nextId(int $serverId, int $seconds, int $milliseconds): int {
 	}
 
 	private function getFilePath(int $fileId): string {
-		return $this->workDir . sprintf(self::LOCK_FILE_FORMAT, $fileId);
+		return $this->tempManager->getTemporaryFolder('.snowflakes') . sprintf(self::LOCK_FILE_FORMAT, $fileId);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -20,12 +20,9 @@ class FileSequence implements ISequence {`
`20`	`20`	`/ Delete sequences after SEQUENCE_TTL seconds /`
`21`	`21`	`private const SEQUENCE_TTL = 30;`
`22`	`22`
`23`		`- private string $workDir;`
`24`		`-`
`25`	`23`	`public function __construct(`
`26`		`- ITempManager $tempManager,`
	`24`	`+ private ITempManager $tempManager,`
`27`	`25`	`) {`
`28`		`- $this->workDir = $tempManager->getTemporaryFolder('.snowflakes');`
`29`	`26`	`}`
`30`	`27`
`31`	`28`	`#[Override]`
`@@ -84,6 +81,6 @@ public function nextId(int $serverId, int $seconds, int $milliseconds): int {`
`84`	`81`	`}`
`85`	`82`
`86`	`83`	`private function getFilePath(int $fileId): string {`
`87`		`- return $this->workDir . sprintf(self::LOCK_FILE_FORMAT, $fileId);`
	`84`	`+ return $this->tempManager->getTemporaryFolder('.snowflakes') . sprintf(self::LOCK_FILE_FORMAT, $fileId);`
`88`	`85`	`}`
`89`	`86`	`}`