fix(reflection): ReflectionMethod::setAccessible is noop since 8.1

Signed-off-by: Joas Schilling <[email protected]>

Author: nickvergessen

apps/files_sharing/tests/SharedMountTest.php

@@ -375,7 +375,6 @@ public function testShareMountOverShare(): void {
 		$mountProvider = Server::get(MountProvider::class);
 		$reflectionClass = new \ReflectionClass($mountProvider);
 		$reflectionCacheFactory = $reflectionClass->getProperty('cacheFactory');
-		$reflectionCacheFactory->setAccessible(true);
 		$reflectionCacheFactory->setValue($mountProvider, $cacheFactory);
 
 		// share to user

tests/lib/HelperStorageTest.php

@@ -102,14 +102,12 @@ public function testGetStorageInfo(): void {
 	private function getIncludeExternalStorage(): bool {
 		$class = new \ReflectionClass(\OC_Helper::class);
 		$prop = $class->getProperty('quotaIncludeExternalStorage');
-		$prop->setAccessible(true);
 		return $prop->getValue(null) ?? false;
 	}
 
 	private function setIncludeExternalStorage(bool $include) {
 		$class = new \ReflectionClass(\OC_Helper::class);
 		$prop = $class->getProperty('quotaIncludeExternalStorage');
-		$prop->setAccessible(true);
 		$prop->setValue(null, $include);
 	}
 

tests/lib/TestCase.php

@@ -248,15 +248,10 @@ protected static function invokePrivate($object, $methodName, array $parameters
 
 		if ($reflection->hasMethod($methodName)) {
 			$method = $reflection->getMethod($methodName);
-
-			$method->setAccessible(true);
-
 			return $method->invokeArgs($object, $parameters);
 		} elseif ($reflection->hasProperty($methodName)) {
 			$property = $reflection->getProperty($methodName);
 
-			$property->setAccessible(true);
-
 			if (!empty($parameters)) {
 				if ($property->isStatic()) {
 					$property->setValue(null, array_pop($parameters));