fix(IShareProvider): Add missing getChildren method to the interface

Signed-off-by: provokateurin <[email protected]>

Author: provokateurin

apps/federatedfilesharing/lib/FederatedShareProvider.php

@@ -431,13 +431,7 @@ public function move(IShare $share, $recipient) {
 		return $share;
 	}
 
-	/**
-	 * Get all children of this share
-	 *
-	 * @param IShare $parent
-	 * @return IShare[]
-	 */
-	public function getChildren(IShare $parent) {
+	public function getChildren(IShare $parent): array {
 		$children = [];
 
 		$qb = $this->dbConnection->getQueryBuilder();

apps/sharebymail/lib/ShareByMailProvider.php

@@ -637,11 +637,6 @@ protected function generateToken(int $size = 15): string {
 		return $token;
 	}
 
-	/**
-	 * Get all children of this share
-	 *
-	 * @return IShare[]
-	 */
 	public function getChildren(IShare $parent): array {
 		$children = [];
 

build/psalm-baseline.xml

@@ -4261,9 +4261,6 @@
     <UndefinedClass>
       <code><![CDATA[\OCA\Circles\Api\v1\Circles]]></code>
     </UndefinedClass>
-    <UndefinedInterfaceMethod>
-      <code><![CDATA[getChildren]]></code>
-    </UndefinedInterfaceMethod>
   </file>
   <file src="lib/private/Share20/ProviderFactory.php">
     <InvalidReturnStatement>

lib/private/Share20/DefaultShareProvider.php

@@ -358,14 +358,7 @@ public function acceptShare(IShare $share, string $recipient): IShare {
 		return $share;
 	}
 
-	/**
-	 * Get all children of this share
-	 * FIXME: remove once https://github.com/owncloud/core/pull/21660 is in
-	 *
-	 * @param \OCP\Share\IShare $parent
-	 * @return \OCP\Share\IShare[]
-	 */
-	public function getChildren(\OCP\Share\IShare $parent) {
+	public function getChildren(IShare $parent): array {
 		$children = [];
 
 		$qb = $this->dbConn->getQueryBuilder();

lib/private/Share20/Manager.php

@@ -1008,7 +1008,6 @@ private function setSharePasswordExpirationTime(IShare $share): void {
 
 	/**
 	 * Delete all the children of this share
-	 * FIXME: remove once https://github.com/owncloud/core/pull/21660 is in
 	 *
 	 * @param IShare $share
 	 * @return IShare[] List of deleted shares

lib/public/Share/IShareProvider.php

@@ -208,4 +208,12 @@ public function getAccessList($nodes, $currentAccess);
 	 * @since 18.0.0
 	 */
 	public function getAllShares(): iterable;
+
+	/**
+	 * Get all children of this share
+	 *
+	 * @return IShare[]
+	 * @since 9.0.0
+	 */
+	public function getChildren(IShare $parent);
 }