Merge pull request #57642 from nextcloud/chore/xhr

chore: drop duplicated legacy Ajax error handling

Author: susnux

core/src/OC/index.js

@@ -73,11 +73,6 @@ import Settings from './settings.js'
 import { theme } from './theme.js'
 import Util from './util.js'
 import webroot from './webroot.js'
-import {
-	ajaxConnectionLostHandler,
-	processAjaxError,
-	registerXHRForErrorProcessing,
-} from './xhr-error.js'
 
 /** @namespace OC */
 export default {
@@ -125,13 +120,11 @@ export default {
 	L10N,
 
 	/**
-	 * Ajax error handlers
+	 * This is already handled by `interceptRequests` in `core/src/init.js`.
 	 *
-	 * @todo remove from here and keep internally -> requires new tests
+	 * @deprecated 33.0.0 - unused by Nextcloud and only a stub remains. Just remove usage.
 	 */
-	_ajaxConnectionLostHandler: ajaxConnectionLostHandler,
-	_processAjaxError: processAjaxError,
-	registerXHRForErrorProcessing,
+	registerXHRForErrorProcessing: () => {},
 
 	/**
 	 * Capabilities

core/src/OC/xhr-error.js

@@ -67,36 +67,6 @@ export function initCore() {
 	interceptRequests()
 	initFallbackClipboardAPI()
 
-	$(window).on('unload.main', () => {
-		OC._unloadCalled = true
-	})
-	$(window).on('beforeunload.main', () => {
-		// super-trick thanks to http://stackoverflow.com/a/4651049
-		// in case another handler displays a confirmation dialog (ex: navigating away
-		// during an upload), there are two possible outcomes: user clicked "ok" or
-		// "cancel"
-
-		// first timeout handler is called after unload dialog is closed
-		setTimeout(() => {
-			OC._userIsNavigatingAway = true
-
-			// second timeout event is only called if user cancelled (Chrome),
-			// but in other browsers it might still be triggered, so need to
-			// set a higher delay...
-			setTimeout(() => {
-				if (!OC._unloadCalled) {
-					OC._userIsNavigatingAway = false
-				}
-			}, 10000)
-		}, 1)
-	})
-	$(document).on('ajaxError.main', function(event, request, settings) {
-		if (settings && settings.allowAuthErrors) {
-			return
-		}
-		OC._processAjaxError(request)
-	})
-
 	initSessionHeartBeat()
 
 	OC.registerMenu($('#expand'), $('#expanddiv'), false, true)