Skip to content

Commit 7a4167f

Browse files
committed
fix(oracle): Don't run tests against unsupported Oracle version anymore
Signed-off-by: Joas Schilling <[email protected]>
1 parent 39e94ef commit 7a4167f

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

.github/workflows/phpunit-oci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ jobs:
6060
fail-fast: false
6161
matrix:
6262
include:
63-
- oracle-versions: '11'
64-
php-versions: '8.2'
6563
- oracle-versions: '18'
6664
php-versions: '8.2'
6765
coverage: ${{ github.event_name != 'pull_request' }}

tests/lib/DB/QueryBuilder/ExpressionBuilderDBTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,16 +142,6 @@ public function testLongText(): void {
142142
}
143143

144144
public function testJson(): void {
145-
if ($this->connection->getDatabaseProvider(true) === IDBConnection::PLATFORM_ORACLE) {
146-
$result = $this->connection->executeQuery('SELECT VERSION FROM PRODUCT_COMPONENT_VERSION');
147-
$version = $result->fetchOne();
148-
$result->closeCursor();
149-
if (str_starts_with($version, '11.')) {
150-
$this->markTestSkipped('JSON is not supported on Oracle 11, skipping until deprecation was clarified: ' . $version);
151-
}
152-
}
153-
154-
155145
$appId = $this->getUniqueID('testing');
156146
$query = $this->connection->getQueryBuilder();
157147
$query->insert('share')

0 commit comments

Comments
 (0)