Skip to content

Commit 82cf6b4

Browse files
committed
fixup! refactor(appstore): migrate app discover section to Vue 3
1 parent 151eb79 commit 82cf6b4

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

apps/appstore/src/components/DiscoverType/DiscoverTypeCarousel.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
- SPDX-License-Identifier: AGPL-3.0-or-later
44
-->
55
<template>
6-
<section :aria-roledescription="t('settings', 'Carousel')" :aria-labelledby="headingId ? `${headingId}` : undefined">
6+
<section :aria-roledescription="t('appstore', 'Carousel')" :aria-labelledby="headingId ? `${headingId}` : undefined">
77
<h3 v-if="headline" :id="headingId">
88
{{ translatedHeadline }}
99
</h3>
@@ -12,7 +12,7 @@
1212
<NcButton
1313
class="app-discover-carousel__button app-discover-carousel__button--previous"
1414
variant="tertiary-no-background"
15-
:aria-label="t('settings', 'Previous slide')"
15+
:aria-label="t('appstore', 'Previous slide')"
1616
:disabled="!hasPrevious"
1717
@click="currentIndex -= 1">
1818
<template #icon>
@@ -35,7 +35,7 @@
3535
<NcButton
3636
class="app-discover-carousel__button app-discover-carousel__button--next"
3737
variant="tertiary-no-background"
38-
:aria-label="t('settings', 'Next slide')"
38+
:aria-label="t('appstore', 'Next slide')"
3939
:disabled="!hasNext"
4040
@click="currentIndex += 1">
4141
<template #icon>
@@ -44,12 +44,12 @@
4444
</NcButton>
4545
</div>
4646
</div>
47-
<div class="app-discover-carousel__tabs" role="tablist" :aria-label="t('settings', 'Choose slide to display')">
47+
<div class="app-discover-carousel__tabs" role="tablist" :aria-label="t('appstore', 'Choose slide to display')">
4848
<NcButton
4949
v-for="index of content.length"
5050
:id="`${internalId}-tab-${index}`"
5151
:key="index"
52-
:aria-label="t('settings', '{index} of {total}', { index, total: content.length })"
52+
:aria-label="t('appstore', '{index} of {total}', { index, total: content.length })"
5353
:aria-controls="`${internalId}-tabpanel-${index}`"
5454
:aria-selected="`${currentIndex === (index - 1)}`"
5555
role="tab"

apps/appstore/src/views/AppstoreDiscover.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
<template>
66
<NcEmptyContent
77
v-if="hasError"
8-
:name="t('settings', 'Nothing to show')"
9-
:description="t('settings', 'Could not load section content from app store.')">
8+
:name="t('appstore', 'Nothing to show')"
9+
:description="t('appstore', 'Could not load section content from app store.')">
1010
<template #icon>
1111
<NcIconSvgWrapper :path="mdiEyeOffOutline" :size="64" />
1212
</template>
1313
</NcEmptyContent>
1414
<NcEmptyContent
1515
v-else-if="elements.length === 0"
16-
:name="t('settings', 'Loading')"
17-
:description="t('settings', 'Fetching the latest news…')">
16+
:name="t('appstore', 'Loading')"
17+
:description="t('appstore', 'Fetching the latest news…')">
1818
<template #icon>
1919
<NcLoadingIcon :size="64" />
2020
</template>
@@ -58,7 +58,7 @@ onBeforeMount(async () => {
5858
} catch (error) {
5959
hasError.value = true
6060
logger.error(error as Error)
61-
showError(t('settings', 'Could not load app discover section'))
61+
showError(t('appstore', 'Could not load app discover section'))
6262
}
6363
})
6464
@@ -77,7 +77,7 @@ function getComponent(type: IAppDiscoverElements['type']) {
7777
}
7878
return defineComponent({
7979
mounted: () => logger.error('Unknown component requested ', type),
80-
render: (h) => h('div', t('settings', 'Could not render element')),
80+
render: (h) => h('div', t('appstore', 'Could not render element')),
8181
})
8282
}
8383
</script>

0 commit comments

Comments
 (0)