refactor(settings): rename user preference keys to snake_case

Signed-off-by: Peter Ringelmann <[email protected]>

Author: Pringels

apps/settings/lib/Controller/UsersController.php

@@ -59,13 +59,13 @@ class UsersController extends Controller {
 	/** Limit for counting users for subadmins, to avoid spending too much time */
 	private const COUNT_LIMIT_FOR_SUBADMINS = 999;
 
-	private const ALLOWED_USER_PREFERENCES = [
-		'userList.showStoragePath',
-		'userList.showUserBackend',
-		'userList.showFirstLogin',
-		'userList.showLastLogin',
-		'userList.showNewUserForm',
-		'userList.showLanguages',
+	public const ALLOWED_USER_PREFERENCES = [
+		'user_list_show_storage_path',
+		'user_list_show_user_backend',
+		'user_list_show_first_login',
+		'user_list_show_last_login',
+		'user_list_show_new_user_form',
+		'user_list_show_languages',
 	];
 
 	public function __construct(

apps/settings/src/store/users.js

@@ -44,12 +44,12 @@ const state = {
 	disabledUsersLimit: 25,
 	userCount: usersSettings.userCount ?? 0,
 	showConfig: {
-		showStoragePath: usersSettings.showConfig['userList.showStoragePath'],
-		showUserBackend: usersSettings.showConfig['userList.showUserBackend'],
-		showFirstLogin: usersSettings.showConfig['userList.showFirstLogin'],
-		showLastLogin: usersSettings.showConfig['userList.showLastLogin'],
-		showNewUserForm: usersSettings.showConfig['userList.showNewUserForm'],
-		showLanguages: usersSettings.showConfig['userList.showLanguages'],
+		showStoragePath: usersSettings.showConfig.user_list_show_storage_path,
+		showUserBackend: usersSettings.showConfig.user_list_show_user_backend,
+		showFirstLogin: usersSettings.showConfig.user_list_show_first_login,
+		showLastLogin: usersSettings.showConfig.user_list_show_last_login,
+		showNewUserForm: usersSettings.showConfig.user_list_show_new_user_form,
+		showLanguages: usersSettings.showConfig.user_list_show_languages,
 	},
 }
 
@@ -807,7 +807,15 @@ const actions = {
 	 */
 	setShowConfig(context, { key, value }) {
 		context.commit('setShowConfig', { key, value })
-		axios.post(generateUrl(`settings/users/preferences/userList.${key}`), { value: value ? 'true' : 'false' })
+		const keyMap = {
+			showStoragePath: 'user_list_show_storage_path',
+			showUserBackend: 'user_list_show_user_backend',
+			showFirstLogin: 'user_list_show_first_login',
+			showLastLogin: 'user_list_show_last_login',
+			showNewUserForm: 'user_list_show_new_user_form',
+			showLanguages: 'user_list_show_languages',
+		}
+		axios.post(generateUrl(`settings/users/preferences/${keyMap[key]}`), { value: value ? 'true' : 'false' })
 			.catch((error) => logger.error(`Could not update ${key} preference`, { error }))
 	},
 }

apps/settings/tests/Controller/UsersControllerTest.php

@@ -1024,12 +1024,12 @@ public static function dataSetPreference(): array {
 		return [
 			['newUser.sendEmail', 'yes', false, true, Http::STATUS_OK],
 			['group.sortBy', '1', false, true, Http::STATUS_OK],
-			['userList.showStoragePath', 'true', true, false, Http::STATUS_OK],
-			['userList.showUserBackend', 'false', true, false, Http::STATUS_OK],
-			['userList.showFirstLogin', 'true', true, false, Http::STATUS_OK],
-			['userList.showLastLogin', 'true', true, false, Http::STATUS_OK],
-			['userList.showNewUserForm', 'true', true, false, Http::STATUS_OK],
-			['userList.showLanguages', 'true', true, false, Http::STATUS_OK],
+			['user_list_show_storage_path', 'true', true, false, Http::STATUS_OK],
+			['user_list_show_user_backend', 'false', true, false, Http::STATUS_OK],
+			['user_list_show_first_login', 'true', true, false, Http::STATUS_OK],
+			['user_list_show_last_login', 'true', true, false, Http::STATUS_OK],
+			['user_list_show_new_user_form', 'true', true, false, Http::STATUS_OK],
+			['user_list_show_languages', 'true', true, false, Http::STATUS_OK],
 			['invalidKey', 'value', false, false, Http::STATUS_FORBIDDEN],
 		];
 	}