fix(files_sharing): Allow deleting a share of a missing file

come-nc · come-nc · commit a60f9494ec32 · 2025-11-24T10:29:46.000+01:00
This can happen in various scenarios, we should allow the user to delete
 the share in this situation.

Signed-off-by: Côme Chilliet &lt;come.chilliet@nextcloud.com&gt;
diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -545,6 +545,8 @@ public function deleteShare(string $id): DataResponse {
 			$this->lock($share->getNode());
 		} catch (LockedException $e) {
 			throw new OCSNotFoundException($this->l->t('Could not delete share'));
+		} catch (NotFoundException $e) {
+			$this->logger->debug('File of deleted share was not found, skip locking', ['exception' => $e]);
 		}
 
 		if (!$this->canAccessShare($share)) {

Original file line number	Diff line number	Diff line change
`@@ -545,6 +545,8 @@ public function deleteShare(string $id): DataResponse {`
`545`	`545`	`$this->lock($share->getNode());`
`546`	`546`	`} catch (LockedException $e) {`
`547`	`547`	`throw new OCSNotFoundException($this->l->t('Could not delete share'));`
	`548`	`+ } catch (NotFoundException $e) {`
	`549`	`+ $this->logger->debug('File of deleted share was not found, skip locking', ['exception' => $e]);`
`548`	`550`	`}`
`549`	`551`
`550`	`552`	`if (!$this->canAccessShare($share)) {`