fix: Also remove digits at the start and underscore on both ends of appid

come-nc · susnux · AndyScherzinger · commit a9ad23e3d8ff · 2025-02-19T18:39:20.000+01:00
Co-authored-by: Ferdinand Thiessen &lt;opensource@fthiessen.de&gt;
Signed-off-by: Côme Chilliet &lt;91878298+come-nc@users.noreply.github.com&gt;
diff --git a/lib/private/App/AppManager.php b/lib/private/App/AppManager.php
@@ -943,6 +943,6 @@ public function isBackendRequired(string $backend): bool {
 	 */
 	public function cleanAppId(string $app): string {
 		/* Only lowercase alphanumeric is allowed */
-		return preg_replace('/[^a-z0-9_]+/', '', $app);
+		return preg_replace('/(^[0-9_]|[^a-z0-9_]+|_$)/', '', $app);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -943,6 +943,6 @@ public function isBackendRequired(string $backend): bool {`
`943`	`943`	`*/`
`944`	`944`	`public function cleanAppId(string $app): string {`
`945`	`945`	`/* Only lowercase alphanumeric is allowed */`
`946`		`- return preg_replace('/[^a-z0-9_]+/', '', $app);`
	`946`	`+ return preg_replace('/(^[0-9_]\|[^a-z0-9_]+\|_$)/', '', $app);`
`947`	`947`	`}`
`948`	`948`	`}`