refactor(setup): use OS constant rather than function (macOS)

joshtrichards · joshtrichards · commit aa498654c532 · 2025-12-02T21:54:44.000-05:00
PHP_OS_FAMILY

- Facilitates elimination of a legacy OC_Util method
  - `runningOnMac()` -- yes, really! ;-)
- Supported since PHP late 7.x-era

Signed-off-by: Josh &lt;josh.t.richards@gmail.com&gt;
diff --git a/lib/private/Setup.php b/lib/private/Setup.php
@@ -185,10 +185,11 @@ public function getSystemInfo(bool $allowAllDatabases = false): array {
 			}
 		}
 
-		if (\OC_Util::runningOnMac()) {
+		// Check if running directly on macOS (note: Linux containers on macOS will not trigger this)
+		if (PHP_OS_FAMILY === 'Darwin') {
 			$errors[] = [
 				'error' => $this->l10n->t(
-					'Mac OS X is not supported and %s will not work properly on this platform. '
+					'macOS is not supported and %s will not work properly on this platform. '
 					. 'Use it at your own risk!',
 					[$this->defaults->getProductName()]
 				),

Original file line number	Diff line number	Diff line change
`@@ -185,10 +185,11 @@ public function getSystemInfo(bool $allowAllDatabases = false): array {`
`185`	`185`	`}`
`186`	`186`	`}`
`187`	`187`
`188`		`- if (\OC_Util::runningOnMac()) {`
	`188`	`+ // Check if running directly on macOS (note: Linux containers on macOS will not trigger this)`
	`189`	`+ if (PHP_OS_FAMILY === 'Darwin') {`
`189`	`190`	`$errors[] = [`
`190`	`191`	`'error' => $this->l10n->t(`
`191`		`- 'Mac OS X is not supported and %s will not work properly on this platform. '`
	`192`	`+ 'macOS is not supported and %s will not work properly on this platform. '`
`192`	`193`	`. 'Use it at your own risk!',`
`193`	`194`	`[$this->defaults->getProductName()]`
`194`	`195`	`),`