Skip to content

Commit adc182c

Browse files
authored
Merge pull request #49304 from nextcloud/feat/dispatcher/log-raw-response-data
feat(Dispatcher): Add debug log for controller methods returning raw data not wrapped in Response
2 parents d61d62b + dd0ed02 commit adc182c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/private/AppFramework/Http/Dispatcher.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,10 @@ private function executeController(Controller $controller, string $methodName):
208208
$response = \call_user_func_array([$controller, $methodName], $arguments);
209209
$this->eventLogger->end('controller:' . get_class($controller) . '::' . $methodName);
210210

211+
if (!($response instanceof Response)) {
212+
$this->logger->debug($controller::class . '::' . $methodName . ' returned raw data. Please wrap it in a Response or one of it\'s inheritors.');
213+
}
214+
211215
// format response
212216
if ($response instanceof DataResponse || !($response instanceof Response)) {
213217
// get format from the url format or request format parameter

0 commit comments

Comments
 (0)