fixup! fixup! feat(snowflake): Use string as type for snowflake ids

Author: CarlSchwan

.github/workflows/phpunit-32bits.yml

@@ -69,4 +69,4 @@ jobs:
           php -f tests/enable_all.php
 
       - name: PHPUnit
-        run: composer run test -- --exclude-group PRIMARY-azure,PRIMARY-s3,PRIMARY-swift,Memcached,Redis,RoutingWeirdness
+        run: lib/composer/bin/phpunit --fail-on-warning --fail-on-risky --display-warnings --display-deprecations --display-phpunit-deprecations --colors=always --configuration tests/phpunit-autotest.xml --exclude-group PRIMARY-azure,PRIMARY-s3,PRIMARY-swift,Memcached,Redis,RoutingWeirdness ../tests/lib/Preview/

lib/private/Preview/Db/Preview.php

@@ -29,8 +29,8 @@
  * @method void setOldFileId(int $oldFileId)
  * @method string getLocationId() Get the location id in the preview_locations table. Only set when using an object store as primary storage.
  * @method void setLocationId(string $locationId)
- * @method string getBucketName() Get the bucket name where the preview is stored. This is stored in the preview_locations table.
- * @method string getObjectStoreName() Get the object store name where the preview is stored. This is stored in the preview_locations table.
+ * @method string|null getBucketName() Get the bucket name where the preview is stored. This is stored in the preview_locations table.
+ * @method string|null getObjectStoreName() Get the object store name where the preview is stored. This is stored in the preview_locations table.
  * @method int getWidth() Get the width of the preview.
  * @method void setWidth(int $width)
  * @method int getHeight() Get the height of the preview.

lib/private/Preview/Generator.php

@@ -542,6 +542,8 @@ public function savePreview(Preview $previewEntry, IImage $preview): Preview {
 		}
 		$previewEntry->setSize($size);
 
+		echo "Inserting preview with id: " . $previewEntry->getId() . PHP_EOL;
+
 		return $this->previewMapper->insert($previewEntry);
 	}
 }

lib/private/Preview/Storage/ObjectStorePreviewStorage.php

@@ -77,6 +77,11 @@ public function readPreview(Preview $preview): mixed {
 
 	#[Override]
 	public function deletePreview(Preview $preview): void {
+		if ($preview->getLocationId() === null) {
+			// Should only be the case in unit tests when adding dummy previews.
+			return;
+		}
+
 		[
 			'urn' => $urn,
 			'store' => $store,
@@ -100,8 +105,8 @@ public function migratePreview(Preview $preview, SimpleFile $file): void {
 	 * @return ObjectStoreDefinition
 	 */
 	private function getObjectStoreInfoForExistingPreview(Preview $preview): array {
-		assert(!empty($preview->getObjectStoreName()));
-		assert(!empty($preview->getBucketName()));
+		assert($preview->getObjectStoreName() !== null);
+		assert($preview->getBucketName() !== null);
 
 		$config = $this->objectStoreConfig->getObjectStoreConfiguration($preview->getObjectStoreName());
 		$config['arguments']['bucket'] = $preview->getBucketName();