Skip to content

Commit e298311

Browse files
authored
Merge pull request #48638 from nextcloud/fix/reasons-to-use
fix: Fix "Reasons to use Nextcloud" design
2 parents d537050 + c4386d4 commit e298311

File tree

6 files changed

+21
-14
lines changed

6 files changed

+21
-14
lines changed

apps/settings/css/settings.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/settings/css/settings.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/settings/css/settings.scss

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,16 @@ select {
132132
}
133133

134134
.link-button {
135-
display: inline-block;
135+
display: inline-flex;
136136
margin: calc(2 * var(--default-grid-baseline));
137137
padding: calc(2 * var(--default-grid-baseline)) calc(4 * var(--default-grid-baseline));
138138
background-color: var(--color-primary-element);
139139
color: var(--color-primary-element-text);
140140
border-radius: var(--border-radius-element);
141141
border: 1px solid var(--color-primary-element);
142142
box-shadow: 0 2px 9px var(--color-box-shadow);
143+
align-items: center;
144+
gap: calc(var(--default-grid-baseline) * 2);
143145

144146
&:hover,
145147
&:focus {
@@ -152,19 +154,13 @@ select {
152154
outline: 2px solid var(--color-main-text) !important;
153155
}
154156

155-
&.icon-file {
156-
padding-inline-start: calc(var(--default-grid-baseline) + var(--default-clickable-area));
157-
background-position: calc(2 * var(--default-grid-baseline));
157+
.icon-file-text {
158+
filter: var(--primary-invert-if-dark);
159+
width: 20px;
160+
height: 20px;
158161
}
159162
}
160163

161-
body[dir='ltr'] .link-button.icon-file {
162-
background-position: left 24px center;
163-
}
164-
body[dir='rtl'] .link-button.icon-file {
165-
background-position: right 24px center;
166-
}
167-
168164
.personal-settings-container {
169165
display: inline-grid;
170166
grid-template-columns: 1fr 1fr 1fr;

apps/settings/templates/settings/personal/development.notice.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
?>
77
<div class="section development-notice">
88
<p>
9-
<a href="<?php p($_['reasons-use-nextcloud-pdf-link']); ?>" id="open-reasons-use-nextcloud-pdf" class="link-button icon-file" target="_blank"><?php p($l->t('Reasons to use Nextcloud in your organization'));?></a>
9+
<a href="<?php p($_['reasons-use-nextcloud-pdf-link']); ?>" id="open-reasons-use-nextcloud-pdf" class="link-button" target="_blank">
10+
<span class="icon-file-text" aria-hidden="true"></span>
11+
<?php p($l->t('Reasons to use Nextcloud in your organization'));?>
12+
</a>
1013
</p>
1114
<p>
1215
<?php print_unescaped(str_replace(

core/src/icons.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,10 @@ const iconsColor = {
179179
path: path.join(__dirname, '../img', 'filetypes', 'text.svg'),
180180
color: 'grey',
181181
},
182+
'file-text': {
183+
path: path.join(__dirname, '../img', 'filetypes', 'text.svg'),
184+
color: 'black',
185+
},
182186
}
183187

184188
// use this to define aliases to existing icons

dist/icons.css

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)