fix(files): Inhibit download for non downloadable nodes in all contexts

artonge · edward-ly · commit ec0ee8779425 · 2026-01-14T07:57:00.000-08:00
Signed-off-by: Louis Chmn &lt;louis@chmn.me&gt;
diff --git a/apps/files/src/components/FileEntryMixin.ts b/apps/files/src/components/FileEntryMixin.ts
@@ -321,7 +321,7 @@ export default defineComponent({
 			const metaKeyPressed = event.ctrlKey || event.metaKey || event.button === 1
 			if (metaKeyPressed || !this.defaultFileAction) {
 				// If no download permission, then we can not allow to download (direct link) the files
-				if (isPublicShare() && !isDownloadable(this.source)) {
+				if (!isDownloadable(this.source)) {
 					return
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ export default defineComponent({`
`321`	`321`	`const metaKeyPressed = event.ctrlKey \|\| event.metaKey \|\| event.button === 1`
`322`	`322`	`if (metaKeyPressed \|\| !this.defaultFileAction) {`
`323`	`323`	`// If no download permission, then we can not allow to download (direct link) the files`
`324`		`- if (isPublicShare() && !isDownloadable(this.source)) {`
	`324`	`+ if (!isDownloadable(this.source)) {`
`325`	`325`	`return`
`326`	`326`	`}`
`327`	`327`