Merge pull request #54413 from nextcloud/perf/render-sharing-tab-sections-only-once

perf: render sharing tab sections only once

Author: szaimen

apps/files_sharing/src/services/TabSections.js

@@ -3,6 +3,14 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+/**
+ * Callback to render a section in the sharing tab.
+ *
+ * @callback registerSectionCallback
+ * @param {undefined} el - Deprecated and will always be undefined (formerly the root element)
+ * @param {object} fileInfo - File info object
+ */
+
 export default class TabSections {
 
 	_sections

apps/files_sharing/src/views/SharingTab.vue

@@ -127,11 +127,10 @@
 					</NcPopover>
 				</div>
 				<!-- additional entries, use it with cautious -->
-				<div v-for="(section, index) in sections"
-					:ref="'section-' + index"
+				<div v-for="(component, index) in sectionComponents"
 					:key="index"
 					class="sharingTab__additionalContent">
-					<component :is="section($refs['section-'+index], fileInfo)" :file-info="fileInfo" />
+					<component :is="component" :file-info="fileInfo" />
 				</div>
 
 				<!-- projects (deprecated as of NC25 (replaced by related_resources) - see instance config "projects.enabled" ; ignore this / remove it / move into own section) -->
@@ -286,6 +285,10 @@ export default {
 				// TRANSLATORS: Type as in with a keyboard
 				: t('files_sharing', 'Type an email or federated cloud ID')
 		},
+
+		sectionComponents() {
+			return this.sections.map((section) => section(undefined, this.fileInfo))
+		},
 	},
 	methods: {
 		/**

dist/6348-6348.js

@@ -0,0 +1 @@
+6348-6348.js.license