refactor(settings): use switch statement in setPreference

Signed-off-by: Peter Ringelmann <[email protected]>

Author: Pringels

apps/settings/lib/Controller/UsersController.php

@@ -267,16 +267,20 @@ public function usersList(INavigationManager $navigationManager, ISubAdmin $subA
 	 */
 	#[AuthorizedAdminSetting(settings:Users::class)]
 	public function setPreference(string $key, string $value): JSONResponse {
-		if (in_array($key, ['newUser.sendEmail', 'group.sortBy'], true)) {
-			if ($key === 'newUser.sendEmail') {
+		switch ($key) {
+			case 'newUser.sendEmail':
 				$this->appConfig->setValueBool('core', $key, $value === 'yes');
-			} else {
+				break;
+			case 'group.sortBy':
 				$this->appConfig->setValueString('core', $key, $value);
-			}
-		} elseif (in_array($key, self::ALLOWED_USER_PREFERENCES, true)) {
-			$this->userConfig->setValueBool($this->userSession->getUser()->getUID(), $this->appName, $key, $value === 'true');
-		} else {
-			return new JSONResponse([], Http::STATUS_FORBIDDEN);
+				break;
+			default:
+				if (in_array($key, self::ALLOWED_USER_PREFERENCES, true)) {
+					$this->userConfig->setValueBool($this->userSession->getUser()->getUID(), $this->appName, $key, $value === 'true');
+				} else {
+					return new JSONResponse([], Http::STATUS_FORBIDDEN);
+				}
+				break;
 		}
 
 		return new JSONResponse([]);