fix(files): translate keyboard shortcuts section title #57226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rajanarahul93 <[email protected]>
rajanarahul93
requested review from
nfebe and
susnux
and removed request for
a team
susnux
requested changes
Dec 22, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
No the NcAppSettingsShortcutsSection is the correct component, it contains proper styles. If there is a problem with the translations then this has to be fixed in the library.
See also https://github.com/nextcloud-libraries/nextcloud-vue
Contributor
|
Thank you for your pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the Keyboard shortcuts section title in the Files settings was always displayed in English, even when translations were available.
The section title is now rendered using the Files app translation domain so existing localized strings are correctly applied.
TODO
Checklist