refactor: Add new modern events for system tag lifecycle#58602
Open
CarlSchwan wants to merge 2 commits intomasterfrom
Open
refactor: Add new modern events for system tag lifecycle#58602CarlSchwan wants to merge 2 commits intomasterfrom
CarlSchwan wants to merge 2 commits intomasterfrom
Conversation
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
CarlSchwan
force-pushed
the
carl/systemtag-lifecycle-event
branch
from
77c26e2 to
63af7c2
Compare
The old one was deprecated in 22.0.0 but didn't had a replacement. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/systemtag-lifecycle-event
branch
from
63af7c2 to
1e3bc59
Compare
come-nc
reviewed
Mar 2, 2026
CarlSchwan
commented
Mar 2, 2026
CarlSchwan
force-pushed
the
carl/systemtag-lifecycle-event
branch
4 times, most recently
from
5870a43 to
1228994
Compare
Member
Author
|
ping :) |
marcelklehr
reviewed
Mar 5, 2026
marcelklehr
reviewed
Mar 5, 2026
|
|
||
| if ($actor !== '' && $event instanceof TagAssignedEvent) { | ||
| foreach ($tags as $tag) { | ||
| $this->updateLastUsedTags($actor, $tag); |
Member
There was a problem hiding this comment.
Last used tags will only be set if the activity app is enabled and only for files tags. Is that intended?
Member
Author
There was a problem hiding this comment.
Behavior wise it is the same as the content in apps/systemtags/lib/Activity/Listener.php (basically copy pasted)
And as far as understand the code, this is not dependent on the activity app being enabled. The IActivityManager will create an activity but since the activity app is not enabled, it will just ignore it and continue
Member
There was a problem hiding this comment.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/systemtag-lifecycle-event
branch
from
1228994 to
443424d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old one was deprecated in 22.0.0 but didn't had a replacement.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)