Skip to content

fix updating cached mounts with multiple entries for root id#58727

Merged
provokateurin merged 2 commits intomasterfrom
mounts-cache-duplicate-rootid
Mar 5, 2026
Merged

fix updating cached mounts with multiple entries for root id#58727
provokateurin merged 2 commits intomasterfrom
mounts-cache-duplicate-rootid

Conversation

@icewind1991
Copy link
Member

  • Also filter for mount_point_hash
  • We don't need to update the mount_point since if that changes they won't be counted as "changed mounts"

…oot id

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 34 milestone Mar 4, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner March 4, 2026 17:45
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 4, 2026
@icewind1991 icewind1991 requested review from Altahrim, artonge, leftybournes and sorbaugh and removed request for a team March 4, 2026 17:45
@icewind1991
Copy link
Member Author

/backport to stable33

@icewind1991
Copy link
Member Author

/backport to stable32

@icewind1991 icewind1991 changed the title Mounts cache duplicate rootid fix updating cached mounts with multiple entries for root id Mar 4, 2026
@icewind1991
Copy link
Member Author

This wasn't noticed earlier because the invalid entries would have been automatically repaired in the next setup.

However #56933 added an index that makes case this throw an error

@provokateurin provokateurin merged commit 687d828 into master Mar 5, 2026
204 of 206 checks passed
@provokateurin provokateurin deleted the mounts-cache-duplicate-rootid branch March 5, 2026 08:46
@backportbot
Copy link

backportbot bot commented Mar 5, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/58727/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d14c4082 9884dec6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58727/stable32

Error: Failed to push branch backport/58727/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants