-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
refactor: drop moment from new bundles #57503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Jan 12, 2026
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
8930444 to
3f79e79
Compare
ShGKme
reviewed
Jan 13, 2026
3f79e79 to
48a0a1f
Compare
Merged
CarlSchwan
approved these changes
Jan 13, 2026
On the Vue 3 side lets remove the dependency on Moment as this is a pretty huge dependency. Instead use plain Intl API for formatting. This reduces the bundle size by ~1.5MiB. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
48a0a1f to
a623bff
Compare
Merged
asavageiv
added a commit
to asavageiv/tasks
that referenced
this pull request
Jan 19, 2026
Following nextcloud/server#57503, this saves about 15% of the zipped bundle size for Tasks. Signed-off-by: Alan Savage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
dependencies
performance 🚀
♻️ refactor
Refactor code (not a bug fix, not a feature just refactoring)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Vue 3 side lets remove the dependency on Moment as this is a pretty huge dependency. Instead use something tiny like dayjs for date computation (end of week / end of day) and use plain Intl API for formatting.
This reduces the bundle size by 9%.
Checklist
3. to review, feature component)stable32)