Skip to content

Commit a259596

Browse files
committed
enh: add cancel button to confirmation dialog
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
1 parent bf94454 commit a259596

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

src/modules/sidebar/partials/ShareList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
:title="t('tables', 'Confirm table manager promotion')"
120120
:cancel-title="t('tables', 'Cancel')"
121121
:confirm-title="t('tables', 'Promote to table manager')"
122-
confirm-class="error"
122+
confirm-class="warning"
123123
:show-modal="showModal"
124124
@confirm="promoteToManager"
125125
@cancel="showModal=false" />

src/shared/modals/DialogConfirmation.vue

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
- SPDX-License-Identifier: AGPL-3.0-or-later
44
-->
55
<template>
6-
<NcModal v-if="showModal" @close="$emit('cancel')">
6+
<NcModal v-if="showModal" :name="t('tables', 'Confirm action')" @close="$emit('cancel')">
77
<div class="modal__content">
88
<div class="row">
99
<div v-if="title" class="col-4">
@@ -14,10 +14,17 @@
1414
</div>
1515
</div>
1616
<div class="row space-T">
17-
<div class="fix-col-4 end">
18-
<NcButton :type="confirmClass" :aria-label="confirmTitle" @click="$emit('confirm')">
19-
{{ confirmTitle }}
20-
</NcButton>
17+
<div class="fix-col-4 space-T justify-between">
18+
<div>
19+
<NcButton :aria-label="cancelTitle" @click="$emit('cancel')">
20+
{{ cancelTitle }}
21+
</NcButton>
22+
</div>
23+
<div>
24+
<NcButton :type="confirmClass" :aria-label="confirmTitle" @click="$emit('confirm')">
25+
{{ confirmTitle }}
26+
</NcButton>
27+
</div>
2128
</div>
2229
</div>
2330
</div>
@@ -46,6 +53,14 @@ export default {
4653
type: String,
4754
default: null,
4855
},
56+
cancelTitle: {
57+
type: String,
58+
default: t('tables', 'Cancel'),
59+
},
60+
cancelClass: {
61+
type: String,
62+
default: 'tertiary',
63+
},
4964
confirmTitle: {
5065
type: String,
5166
default: t('tables', 'Confirm'),

0 commit comments

Comments
 (0)