fix: update context navigation display elements

Signed-off-by: Cleopatra Enjeck M <[email protected]>

Author: enjeck

lib/Service/ShareService.php

@@ -334,6 +334,7 @@ public function updateDisplayMode(int $shareId, int $displayMode, string $userId
 				}
 			} else {
 				// setting user display mode override only requires access
+				// this does not seem to work
 				if (!$this->permissionsService->canAccessContextById($item->getId())) {
 					throw new PermissionError(sprintf('PermissionError: can not update share with id %d', $shareId));
 				}

src/modules/modals/CreateContext.vue

@@ -41,19 +41,19 @@
 			</div>
 			<div class="row space-T">
 				<div>
-					{{ t('tables', 'Navigation bar entry') }}
+					{{ t('tables', 'Navigation bar display') }}
 				</div>
 				<NcCheckboxRadioSwitch :checked.sync="displayMode" value="NAV_ENTRY_MODE_HIDDEN"
 					name="NAV_ENTRY_MODE_HIDDEN" type="radio">
-					No navigation bar entry
+					Hide navigation entry for everybody
 				</NcCheckboxRadioSwitch>
 				<NcCheckboxRadioSwitch :checked.sync="displayMode" value="NAV_ENTRY_MODE_RECIPIENTS"
 					name="NAV_ENTRY_MODE_RECIPIENTS" type="radio">
-					Navigation bar entry for share recipients, but not the owner
+					Show navigation entry for everybody, except me
 				</NcCheckboxRadioSwitch>
 				<NcCheckboxRadioSwitch :checked.sync="displayMode" value="NAV_ENTRY_MODE_ALL" name="NAV_ENTRY_MODE_ALL"
 					type="radio">
-					Navigation bar entry for everybody
+					Show navigation entry for everybody
 				</NcCheckboxRadioSwitch>
 				<br>
 			</div>

src/modules/modals/EditContext.vue

@@ -35,7 +35,24 @@
 				</div>
 				<NcContextResource :resources.sync="resources" :receivers.sync="receivers" />
 			</div>
-
+			<div class="row space-T">
+				<div>
+					{{ t('tables', 'Navigation bar display') }}
+				</div>
+				<NcCheckboxRadioSwitch :checked.sync="displayMode" value="NAV_ENTRY_MODE_HIDDEN"
+					name="NAV_ENTRY_MODE_HIDDEN" type="radio">
+					Hide navigation entry for everybody
+				</NcCheckboxRadioSwitch>
+				<NcCheckboxRadioSwitch :checked.sync="displayMode" value="NAV_ENTRY_MODE_RECIPIENTS"
+					name="NAV_ENTRY_MODE_RECIPIENTS" type="radio">
+					Show navigation entry for everybody, except me
+				</NcCheckboxRadioSwitch>
+				<NcCheckboxRadioSwitch :checked.sync="displayMode" value="NAV_ENTRY_MODE_ALL" name="NAV_ENTRY_MODE_ALL"
+					type="radio">
+					Show navigation entry for everybody
+				</NcCheckboxRadioSwitch>
+				<br>
+			</div>
 			<div class="row space-T">
 				<div class="fix-col-4 space-T justify-between">
 					<NcButton v-if="!prepareDeleteContext" type="error" @click="prepareDeleteContext = true">
@@ -59,7 +76,7 @@
 </template>
 
 <script>
-import { NcModal, NcButton, NcIconSvgWrapper } from '@nextcloud/vue'
+import { NcModal, NcButton, NcIconSvgWrapper, NcCheckboxRadioSwitch } from '@nextcloud/vue'
 import { showError, showSuccess } from '@nextcloud/dialogs'
 import { getCurrentUser } from '@nextcloud/auth'
 import '@nextcloud/dialogs/dist/index.css'
@@ -71,6 +88,7 @@ import svgHelper from '../../shared/components/ncIconPicker/mixins/svgHelper.js'
 import permissionBitmask from '../../shared/components/ncContextResource/mixins/permissionBitmask.js'
 import { emit } from '@nextcloud/event-bus'
 import permissionsMixin from '../../shared/components/ncTable/mixins/permissionsMixin.js'
+import { NAV_ENTRY_MODE } from '../../shared/constants.js'
 
 export default {
 	name: 'EditContext',
@@ -80,6 +98,7 @@ export default {
 		NcIconPicker,
 		NcIconSvgWrapper,
 		NcContextResource,
+		NcCheckboxRadioSwitch,
 	},
 	mixins: [svgHelper, permissionBitmask, permissionsMixin],
 	props: {
@@ -108,6 +127,7 @@ export default {
 			PERMISSION_UPDATE,
 			PERMISSION_DELETE,
 			prepareDeleteContext: false,
+			displayMode: 'NAV_ENTRY_MODE_HIDDEN', // TODO: get the actual saved display mode
 		}
 	},
 	computed: {

src/modules/navigation/partials/NavigationContextItem.vue

@@ -11,7 +11,8 @@
 			</template>
 		</template>
 		<template #actions>
-			<NcActionButton v-if="ownsContext(context)" :close-after-click="true" data-cy="navigationContextEditBtn" @click="editContext">
+			<NcActionButton v-if="ownsContext(context)" :close-after-click="true" data-cy="navigationContextEditBtn"
+				@click="editContext">
 				<template #icon>
 					<PlaylistEdit :size="20" />
 				</template>
@@ -23,13 +24,14 @@
 				</template>
 				{{ t('tables', 'Transfer application') }}
 			</NcActionButton>
-			<NcActionButton v-if="ownsContext(context)" :close-after-click="true" data-cy="navigationContextDeleteBtn" @click="deleteContext">
+			<NcActionButton v-if="ownsContext(context)" :close-after-click="true" data-cy="navigationContextDeleteBtn"
+				@click="deleteContext">
 				<template #icon>
 					<Delete :size="20" />
 				</template>
 				{{ t('tables', 'Delete application') }}
 			</NcActionButton>
-			<NcActionCheckbox :value="showInNavigation" @change="updateDisplayMode">
+			<NcActionCheckbox v-if="!ownsContext(context)" :value="showInNavigation" @change="updateDisplayMode">
 				Show in Navigation
 			</NcActionCheckbox>
 		</template>
@@ -47,6 +49,7 @@ import Delete from 'vue-material-design-icons/Delete.vue'
 import permissionsMixin from '../../../shared/components/ncTable/mixins/permissionsMixin.js'
 import svgHelper from '../../../shared/components/ncIconPicker/mixins/svgHelper.js'
 import { getCurrentUser } from '@nextcloud/auth'
+import { NAV_ENTRY_MODE } from '../../../shared/constants.js'
 
 export default {
 	name: 'NavigationContextItem',
@@ -74,7 +77,7 @@ export default {
 	data() {
 		return {
 			icon: null,
-			showInNavigation: false,
+			showInNavigation: this.getDisplayMode(),
 		}
 	},
 	computed: {
@@ -101,13 +104,18 @@ export default {
 		deleteContext() {
 			emit('tables:context:delete', this.context)
 		},
+		getDisplayMode() {
+			const share = Object.values(this.context.sharing || {}).find(share => share.receiver === getCurrentUser().uid)
+			if (share) {
+				return share.display_mode
+			}
+			return 0
+		},
 		updateDisplayMode() {
-			this.showInNavigation = !this.showInNavigation
-			if (this.context) {
-				const share = Object.values(this.context.sharing || {}).find(share => share.receiver === getCurrentUser().uid)
-				if (share) {
-					this.$store.dispatch('updateDisplayMode', { shareId: share.share_id, displayMode: this.showInNavigation ? 1 : 0, userId: getCurrentUser().uid })
-				}
+			this.showInNavigation = this.showInNavigation ? 0 : 1
+			const share = Object.values(this.context.sharing || {}).find(share => share.receiver === getCurrentUser().uid)
+			if (share) {
+				this.$store.dispatch('updateDisplayMode', { shareId: share.share_id, displayMode: this.showInNavigation ? NAV_ENTRY_MODE['NAV_ENTRY_MODE_RECIPIENTS'] : NAV_ENTRY_MODE['NAV_ENTRY_MODE_HIDDEN'], target: 'self' })
 			}
 		},
 	},

src/shared/constants.js

@@ -43,7 +43,7 @@ export const TYPE_DATETIME = 'datetime'
 export const TYPE_USERGROUP = 'usergroup'
 
 export const NAV_ENTRY_MODE = {
-	NAV_ENTRY_MODE_HIDDEN: 0,
-	NAV_ENTRY_MODE_RECIPIENTS: 1,
-	NAV_ENTRY_MODE_ALL: 2,
+	NAV_ENTRY_MODE_HIDDEN: 0, // no nav bar entry
+	NAV_ENTRY_MODE_RECIPIENTS: 1, // nav bar entry for share recipients, but not the owner
+	NAV_ENTRY_MODE_ALL: 2, // nav bar entry for everybody
 }

src/store/store.js

@@ -377,9 +377,9 @@ export default new Vuex.Store({
 			}
 		},
 
-		async updateDisplayMode({ dispatch }, { shareId, displayMode, userId }) {
+		async updateDisplayMode({ dispatch }, { shareId, displayMode, target }) {
 			try {
-				await axios.put(generateUrl('/apps/tables/share/' + shareId + '/display-mode'), { displayMode, userId })
+				await axios.put(generateUrl('/apps/tables/share/' + shareId + '/display-mode'), { displayMode, target })
 			} catch (e) {
 				displayError(e, t('tables', 'Could not update display mode.'))
 			}