Skip to content

Commit e43d48b

Browse files
committed
fix(Cypress): update selectors for confirmation dialog
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
1 parent 876a75d commit e43d48b

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

cypress/support/commands.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -470,8 +470,8 @@ Cypress.Commands.add('addUserToGroup', (userId, groupId) => {
470470

471471
Cypress.Commands.add('removeColumn', (title) => {
472472
cy.get('.custom-table table tr th .cell').contains(title).click()
473-
cy.get('.v-popper__popper ul.nc-button-group-content').last().get('button').last().click()
474-
cy.get('.modal__content button').contains('Confirm').click()
473+
cy.get('[data-cy="deleteColumnActionBtn"] button').click()
474+
cy.get('[data-cy="confirmDialog"] button').contains('Confirm').click()
475475
})
476476

477477
// fill in a value in the 'create row' or 'edit row' model

src/shared/components/ncTable/partials/TableHeaderColumnOptions.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@
110110
</NcActionButton>
111111
<NcActionButton v-if="showDeleteColumn"
112112
:aria-label="t('tables', 'Delete column')"
113+
data-cy="deleteColumnActionBtn"
113114
@click="deleteColumn()">
114115
<template #icon>
115116
<Delete :size="25" />

src/shared/modals/DialogConfirmation.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
-->
55
<template>
66
<NcDialog v-if="showModal" :out-transition="true"
7-
size="normal" close-on-click-outside :name="title" @closing="$emit('cancel')">
7+
size="normal" close-on-click-outside :name="title" @closing="$emit('cancel')"
8+
data-cy="confirmDialog">
89
<div class="row">
910
<div v-if="description" class="col-4">
1011
<p>{{ description }}</p>

0 commit comments

Comments
 (0)