Skip to content

Commit 9426f87

Browse files
committed
fix linter errors
1 parent 27b0ada commit 9426f87

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

src/app/githubReleaseNotification.service.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,9 @@ function stopReleaseNotificationScheduler() {
146146
* Register IPC handlers used by renderers
147147
*/
148148
function registerUpdateIpcHandlers() {
149-
if (!ipcMain) return
149+
if (!ipcMain) {
150+
return
151+
}
150152
ipcMain.handle('github-release:check', async () => {
151153
try {
152154
const result = await checkForNewVersion({ })

src/preload.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,11 @@ const TALK_DESKTOP = {
195195
/**
196196
* Listen for push notifications about new releases
197197
*
198-
* @param {(data:{available:boolean,tag:string|null,url:string|null}) => void} callback
198+
* @param {() => void} callback - Callback
199199
* @return {() => void} unsubscribe
200200
*/
201201
onNewVersion: (callback) => {
202-
const handler = (event, data) => callback(data)
202+
const handler = () => callback()
203203
ipcRenderer.on('github-release:new-version', handler)
204204
return () => ipcRenderer.removeListener('github-release:new-version', handler)
205205
},

src/talk/renderer/TitleBar/components/MainMenu.vue

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,19 @@ import type { Ref } from 'vue'
88
99
import { t } from '@nextcloud/l10n'
1010
import { generateUrl } from '@nextcloud/router'
11-
import { inject, ref, onMounted, onBeforeUnmount } from 'vue'
11+
import { inject, onBeforeUnmount, onMounted, ref } from 'vue'
1212
import NcActionButton from '@nextcloud/vue/components/NcActionButton'
1313
import NcActionLink from '@nextcloud/vue/components/NcActionLink'
1414
import NcActions from '@nextcloud/vue/components/NcActions'
1515
import NcActionSeparator from '@nextcloud/vue/components/NcActionSeparator'
1616
import IconBugOutline from 'vue-material-design-icons/BugOutline.vue'
17+
import IconCircle from 'vue-material-design-icons/Circle.vue'
18+
import IconCloudDownloadOutline from 'vue-material-design-icons/CloudDownloadOutline.vue'
1719
import IconCogOutline from 'vue-material-design-icons/CogOutline.vue'
1820
import IconInformationOutline from 'vue-material-design-icons/InformationOutline.vue'
1921
import IconMenu from 'vue-material-design-icons/Menu.vue'
2022
import IconReload from 'vue-material-design-icons/Reload.vue'
2123
import IconWeb from 'vue-material-design-icons/Web.vue'
22-
import IconCloudDownloadOutline from 'vue-material-design-icons/CloudDownloadOutline.vue'
23-
import IconCircle from 'vue-material-design-icons/Circle.vue'
2424
import { BUILD_CONFIG } from '../../../../shared/build.config.ts'
2525
import { getCurrentTalkRoutePath } from '../../TalkWrapper/talk.service.ts'
2626
@@ -43,7 +43,9 @@ onMounted(() => {
4343
window.TALK_DESKTOP.checkForUpdate()
4444
})
4545
onBeforeUnmount(() => {
46-
if (typeof unsubscribeNewVersion === 'function') unsubscribeNewVersion()
46+
if (typeof unsubscribeNewVersion === 'function') {
47+
unsubscribeNewVersion()
48+
}
4749
})
4850
4951
</script>
@@ -61,7 +63,7 @@ onBeforeUnmount(() => {
6163
</template>
6264

6365
<template v-if="isTalkInitialized">
64-
<NcActionButton @click="openInWeb" :close-after-click="true">
66+
<NcActionButton close-after-click @click="openInWeb">
6567
<template #icon>
6668
<IconWeb :size="20" />
6769
</template>
@@ -77,17 +79,19 @@ onBeforeUnmount(() => {
7779
</template>
7880
{{ t('talk_desktop', 'Force reload') }}
7981
</NcActionButton>
80-
<NcActionLink v-if="updateAvailable"
81-
:close-after-click="true"
82+
<NcActionLink
83+
v-if="updateAvailable"
84+
close-after-click
8285
href="https://github.com/nextcloud/talk-desktop/releases/latest"
8386
target="_blank">
8487
<template #icon>
8588
<IconCloudDownloadOutline :size="20" />
8689
</template>
8790
{{ t('talk_desktop', 'Update available!\nDownload latest version') }}
8891
</NcActionLink>
89-
<NcActionLink v-if="!BUILD_CONFIG.isBranded"
90-
:close-after-click="true"
92+
<NcActionLink
93+
v-if="!BUILD_CONFIG.isBranded"
94+
close-after-click
9195
:href="packageInfo.bugs.create || packageInfo.bugs.url"
9296
target="_blank">
9397
<template #icon>
@@ -104,7 +108,7 @@ onBeforeUnmount(() => {
104108
</template>
105109
{{ t('talk_desktop', 'App settings') }}
106110
</NcActionButton>
107-
<NcActionButton @click="showHelp" :close-after-click="true">
111+
<NcActionButton close-after-click @click="showHelp">
108112
<template #icon>
109113
<IconInformationOutline :size="20" />
110114
</template>

0 commit comments

Comments
 (0)