Skip to content

Commit c200d08

Browse files
committed
fixup! refactor(user-status): improve useHeartbeat
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
1 parent a3f8c15 commit c200d08

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/talk/renderer/UserStatus/useHeartbeat.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ import { useUserStatusStore } from './userStatus.store.ts'
1111
// General notes:
1212
// - Server has INVALIDATE_STATUS_THRESHOLD with 15 minutes, preventing immediate status update on heartbeat request
1313
// See: https://github.com/nextcloud/server/blob/v31.0.5/apps/user_status/lib/Service/StatusService.php
14-
// - However, "away" status has higher priority than "online"
15-
// See: https://github.com/nextcloud/server/blob/v31.0.5/apps/user_status/lib/Service/StatusService.php#L41-L48
14+
// - However, "online" status has higher priority than "away"
1615
// - Thus:
17-
// - Changing "Away -> Online" has a 15 minutes threshold
18-
// - Changing "Online -> Away" is immediate
19-
// - See: https://github.com/nextcloud/server/blob/master/apps/user_status/lib/Listener/UserLiveStatusListener.php#L75-L87
16+
// - Changing "Away -> Online" is immediate
17+
// - Changing "Online -> Away" has a 15 minutes threshold
18+
// - See: https://github.com/nextcloud/server/blob/v31.0.5/apps/user_status/lib/Service/StatusService.php#L41-L48
19+
// and: https://github.com/nextcloud/server/blob/master/apps/user_status/lib/Listener/UserLiveStatusListener.php#L75-L87
2020
// - This might change in future to have symmetric behavior on heartbeat
2121

2222
/** How often to send the heartbeat. Must be less than 15 min. */

0 commit comments

Comments
 (0)